Repository navigation
TST: Set tests touched by text overhaul to mpl20 style - #31300
QuLogic merged 2 commits into
Conversation
Sorry, something went wrong.
|
This is now all set, except that the following tests fail on macOS only: FAILED lib/matplotlib/tests/test_axes.py::test_canonical[png] - matplotlib.testing.exceptions.ImageComparisonFailure: images not close (RMS 0.028): result_images/test_axes/canonical.png result_images/test_axes/canonical-expected.png result_images/test_axes/canonical-failed-diff.png FAILED lib/matplotlib/tests/test_axes.py::test_set_get_ticklabels[png] - matplotlib.testing.exceptions.ImageComparisonFailure: images not close (RMS 0.029): result_images/test_axes/set_get_ticklabels.png result_images/test_axes/set_get_ticklabels-expected.png result_images/test_axes/set_get_ticklabels-failed-diff.png FAILED lib/matplotlib/tests/test_figure.py::test_figure[png] - matplotlib.testing.exceptions.ImageComparisonFailure: images not close (RMS 0.021): result_images/test_figure/figure_today.png result_images/test_figure/figure_today-expected.png result_images/test_figure/figure_today-failed-diff.png FAILED lib/mpl_toolkits/axes_grid1/tests/test_axes_grid1.py::test_zooming_with_inverted_axes[png] - matplotlib.testing.exceptions.ImageComparisonFailure: images not close (RMS 0.022): result_images/test_axes_grid1/zoomed_axes.png result_images/test_axes_grid1/zoomed_axes-expected.png result_images/test_axes_grid1/zoomed_axes-failed-diff.png FAILED lib/matplotlib/tests/test_legend.py::test_labels_first[png] - matplotlib.testing.exceptions.ImageComparisonFailure: images not close (RMS 0.014): result_images/test_legend/legend_labels_first.png result_images/test_legend/legend_labels_first-expected.png result_images/test_legend/legend_labels_first-failed-diff.png FAILED lib/matplotlib/tests/test_legend.py::test_multiple_keys[png] - matplotlib.testing.exceptions.ImageComparisonFailure: images not close (RMS 0.032): result_images/test_legend/legend_multiple_keys.png result_images/test_legend/legend_multiple_keys-expected.png result_images/test_legend/legend_multiple_keys-failed-diff.png I am extremely surprised by the first one, as that's about the simplest plot there is. |
Sorry, something went wrong.
|
Using our standard diff, it is basically invisible, but using imagemagick, the diff is: |
Sorry, something went wrong.
|
Also odd that the mises are not uniform across the line. |
Sorry, something went wrong.
|
@ksunden Looked into this and they all already have tolerances and changing the style changes amount of tolerance we needs. Lets merge this and deal with the tolerances in the other PR. Rough theory as to the distribution: we are seeing accumulated errors as a function of distance across the axis so the diagonal line is sampling different parts of that at different heights. |
Sorry, something went wrong.
|
Specifically, all of these tests already had tolerances from the old style, the RMS just got higher than we had encoded. This is due to a number of factors, likely
All of these tests are plotting some form of y=x+C lines (e.g. ax.plot([1,2,3]) or ax.plot(np.arange(5), etc) so it is really only that one particular line that needs this adjustment, just frustrating that it is such a simple and common case... |
Sorry, something went wrong.
|
🤦♂️ I was looking at this from the reset-tolerances branch, and thus was confused because I thought all of these tests already had zero tolerance. Of course, if they all had one and it's just a tiny bit more now, that's quite alright. |
Sorry, something went wrong.
This includes images changes for the following pull requests / commits: * [Fix center of rotation with rotation_mode='anchor'](matplotlib#29199) (c44db77) * [Remove ttconv backwards-compatibility code](matplotlib#30145) (8caff88) * [Remove kerning_factor from tests](matplotlib#29816) (7b4d725) * [Set text hinting to defaults](matplotlib#29816) (8255ae2) * [Update FreeType to 2.13.3](matplotlib#29816) (89c054d) * [Implement text shaping with libraqm](matplotlib#30000) (b0ded3a, 9813523) * [Add language parameter to Text objects](matplotlib#29794) (7ce8eae) * [Fix auto-sized glyphs with BaKoMa fonts](matplotlib#29936) (3ba2c13) * [pdf: Improve text with characters outside embedded font limits](matplotlib#30512) (b70fb88, 6cedcf7) * [Prepare `CharacterTracker` for advanced font features](matplotlib#30608) (8274e17, 70dc388, df670cf, ed5e074) * [Add font feature API to Text](matplotlib#29695) (972a688) * [Fix spacing in r"$\max f$"](matplotlib#30715) (4a99a83) * [Implement libraqm for vector outputs](matplotlib#30607) (bd17cd4) * [Drop the FT2Font intermediate buffer](matplotlib#30059) (9d7d7b4) * [Rasterize dvi files without dvipng](matplotlib#30039) (7627118) * [Update bundled FreeType and HarfBuzz libraries](matplotlib#30938) (a161658, 9619bcc) * [Fix positioning of wide mathtext accents](matplotlib#31069) (c2fa7ba) * [Refactor RendererAgg.draw_{mathtext,text,tex} to use same base algorithm](matplotlib#31085) (931bcf3) * [Implement TeX's fraction and script alignment](matplotlib#31046) (94ff452, 4bfa0f9, 1cd8510) * [Fix confusion between text height and ascent in metrics calculations](matplotlib#31107) (60f2310) * [mathtext: Fetch quad width & axis height from font metrics](matplotlib#31110) (692df3f, 383028b) * [mathtext: add mathnormal and distinguish between normal and italic family](matplotlib#31121) (a6913f3) * [ENH: Ignore empty text for tightbbox](matplotlib#31285) (d772043) * [Drop axis_artist tickdir image compat, due to text-overhaul merge](matplotlib#31281) (2057583) * [text: Use font metrics to determine line heights](matplotlib#31291) (3ab6a27, d961462, 97f4943) * [ps/pdf: Override font height metrics to support AFM files](matplotlib#31371) (e0913d4) * [TST: Cleanup back-compat code in tests touched by text overhaul](matplotlib#31295) (7c33379) * [TST: Set tests touched by text overhaul to mpl20 style](matplotlib#31300) (41c4d8d)
PR summary
This is based on several other PRs to make it easier for me to track what needs changing. I will rebase those extra commits out once ready.
The first commit changes all related tests to mpl20, while the second commit changes a few so that they better work in the new style (e.g., moves a transparent legend over top something so that you can actually confirm that it's transparent.) I do expect to squash these together, but kept them separate so that it'd be easier to review the secondary changes.
AI Disclosure
None
PR checklist