| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Please rerun CI: I have no idea what's causing the failure |
Sorry, something went wrong.
|
⏰ This pull request might be automatically closed in two weeks from now. Thank you for your contribution to Matplotlib and for the effort you have put into this PR. This pull request does not yet meet the quality and clarity standards needed for an effective review. Project maintainers have limited time for code reviews, and our goal is to prioritize well-prepared contributions to keep Matplotlib maintainable. Matplotlib maintainers cannot provide one-to-one guidance on this PR. However, if you ask focused, well-researched questions, a community member may be willing to help. 💬 To increase the chance of a productive review:
As the author, you are responsible for driving this PR, which entails doing necessary background research as well as presenting its context and your thought process. If you are a new contributor, or do not know how to fulfill these requirements, we recommend that you familiarize yourself with Matplotlib's development conventions or engage with the community via our Discourse or one of our meetings before submitting code. If you substantially improve this PR within two weeks, leave a comment and a team member may remove the status: autoclose candidate label and the PR stays open. Cosmetic changes or incomplete fixes will not be sufficient. Maintainers will assess improvements on their own schedule. Please do not ping (@) maintainers. |
Sorry, something went wrong.
|
I do not know why the the AppVeyor stage is failing everywhere: https://ci.appveyor.com/project/matplotlib/matplotlib/builds/54613753 Command exited with code 1
python tools/visualize_tests.py --no-browser
Traceback (most recent call last):
File "C:\projects\matplotlib\tools\visualize_tests.py", line 160, in <module>
run(show_browser=not args.no_browser)
File "C:\projects\matplotlib\tools\visualize_tests.py", line 64, in run
for name in os.listdir(image_dir)
^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [WinError 3] The system cannot find the path specified: 'result_images'
Command exited with code 1
|
Sorry, something went wrong.
|
HI @clin1234 , you still haven't updated the PR description as requested. You should likely rebase for AppVeyor to pass here (see #32096 (comment)) |
Sorry, something went wrong.
| @@ -0,0 +1,103 @@ | |||
| # Stub generated from the C++ (pybind11) signatures in | |||
There was a problem hiding this comment.
I have a branch which adds a lot of typing to the backends, can we drop this file?
Sorry, something went wrong.
There was a problem hiding this comment.
Which branch?
Sorry, something went wrong.
| def get_width_height(self) -> tuple[int, int]: ... | ||
| def load_char(self, charcode: CharacterCodeType, flags: LoadFlags = ...) -> Glyph: ... | ||
| def load_glyph(self, glyphindex: GlyphIndexType, flags: LoadFlags = ...) -> Glyph: ... | ||
| def load_glyph(self, glyph_index: GlyphIndexType, flags: LoadFlags = ...) -> Glyph: ... |
There was a problem hiding this comment.
How have these errors been escaping our testing?
Sorry, something went wrong.
|
Thank you for your interest in contributing to Matplotlib, but we cannot accept your contribution as this pull request does not meet our development standards. Following our review policy, we are closing this PR after allowing two weeks time for improvements. Thank you for your understanding. If you think your PR has been closed by mistake, please comment below. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR summary
Closes #31424. In particular:
AI Disclosure
No AI was used.
PR quality check