FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Annotate missing mypy stubs by clin1234 · Pull Request #32097 · matplotlib/matplotlib · GitHub

Repository navigation

Annotate missing mypy stubs - #32097

Open
clin1234 wants to merge 1 commit into
matplotlib:mainfrom
clin1234:typestub
Open

clin1234 wants to merge 1 commit into
matplotlib:mainfrom
clin1234:typestub

Conversation

clin1234 commented Jul 22, 2026 •
edited
Loading

Copy link
Copy Markdown

PR summary

Closes #31424. In particular:

  • Add mypy stubs for _backend_agg, _macosx, and qhull
  • Sequence[BboxBase] -> np.ndarray to reflect implementation in .cpp files
  • In ft2font.pyi, draw_glyph_to_bitmap and draw_glyphs_to_bitmap take variable positional args
  • Make the various interpolation types enum members, as seen in image.cpp

AI Disclosure

No AI was used.

PR quality check

  • Use an expressive title, e.g. "Fix title font property precedence"
  • New and changed code is tested
  • Plotting related features are demonstrated in an example
  • New features and API changes have release notes
  • Documentation complies with general and docstring guidelines

Copy link
Copy Markdown
Author

Please rerun CI: I have no idea what's causing the failure

melissawm added the status: autoclose candidate PRs that are not yet ready for review and may be automatically closed in two weeks label Aug 26, 2026

Copy link
Copy Markdown

⏰ This pull request might be automatically closed in two weeks from now.

Thank you for your contribution to Matplotlib and for the effort you have put into this PR. This pull request does not yet meet the quality and clarity standards needed for an effective review. Project maintainers have limited time for code reviews, and our goal is to prioritize well-prepared contributions to keep Matplotlib maintainable.

Matplotlib maintainers cannot provide one-to-one guidance on this PR. However, if you ask focused, well-researched questions, a community member may be willing to help. 💬

To increase the chance of a productive review:

As the author, you are responsible for driving this PR, which entails doing necessary background research as well as presenting its context and your thought process. If you are a new contributor, or do not know how to fulfill these requirements, we recommend that you familiarize yourself with Matplotlib's development conventions or engage with the community via our Discourse or one of our meetings before submitting code.

If you substantially improve this PR within two weeks, leave a comment and a team member may remove the status: autoclose candidate label and the PR stays open. Cosmetic changes or incomplete fixes will not be sufficient. Maintainers will assess improvements on their own schedule. Please do not ping (@) maintainers.

clin1234 marked this pull request as draft August 26, 2026 15:01
clin1234 marked this pull request as ready for review August 27, 2026 13:12

Copy link
Copy Markdown
Author

I do not know why the the AppVeyor stage is failing everywhere:

https://ci.appveyor.com/project/matplotlib/matplotlib/builds/54613753

Command exited with code 1
python tools/visualize_tests.py --no-browser
Traceback (most recent call last):
  File "C:\projects\matplotlib\tools\visualize_tests.py", line 160, in <module>
    run(show_browser=not args.no_browser)
  File "C:\projects\matplotlib\tools\visualize_tests.py", line 64, in run
    for name in os.listdir(image_dir)
                ^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [WinError 3] The system cannot find the path specified: 'result_images'
Command exited with code 1

Copy link
Copy Markdown
Member

HI @clin1234 , you still haven't updated the PR description as requested.

You should likely rebase for AppVeyor to pass here (see #32096 (comment))

@@ -0,0 +1,103 @@
# Stub generated from the C++ (pybind11) signatures in

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I have a branch which adds a lot of typing to the backends, can we drop this file?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Which branch?

def get_width_height(self) -> tuple[int, int]: ...
def load_char(self, charcode: CharacterCodeType, flags: LoadFlags = ...) -> Glyph: ...
def load_glyph(self, glyphindex: GlyphIndexType, flags: LoadFlags = ...) -> Glyph: ...
def load_glyph(self, glyph_index: GlyphIndexType, flags: LoadFlags = ...) -> Glyph: ...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

How have these errors been escaping our testing?

Copy link
Copy Markdown

Thank you for your interest in contributing to Matplotlib, but we cannot accept your contribution as this pull request does not meet our development standards.

Following our review policy, we are closing this PR after allowing two weeks time for improvements.

Thank you for your understanding. If you think your PR has been closed by mistake, please comment below.

github-actions Bot closed this Sep 11, 2026
tacaswell removed the status: autoclose candidate PRs that are not yet ready for review and may be automatically closed in two weeks label Sep 11, 2026
tacaswell reopened this Sep 11, 2026

Copy link
Copy Markdown
Author

@melissawm @tacaswell ping

clin1234 requested a review from tacaswell October 11, 2026 08:58

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Umbrella issue: matplotlib C/C++ Extension Analysis Report

3 participants


Back | FazBrowse Home | New Git URL