TST: Set subprocess timeouts consistently on CI - #32198
Open
QuLogic wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Some places do, and some places don't, increase the timeout when running on CI. Instead of having that accidental inconsistency, increase the timeout for everything in the helper function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Some places do, and some places don't, increase the timeout when running on CI. Instead of having that accidental inconsistency, increase the timeout for everything in the helper function.
For example, I've just now seen test_dpi_change_triggers_resize fail, and it has a fixed timeout of 60 instead of raising it to 120 like other tests.
AI Disclosure
None
PR quality check