Repository navigation
Use existing np.arrays when calling _qhull.delaunay - #32417
Merged
scottshambaugh merged 1 commit intoOct 1, 2026
Merged
scottshambaugh merged 1 commit into
scottshambaugh merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
1 task done
ianthomas23
approved these changes
Oct 1, 2026
scottshambaugh
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Triangulation.__init__ converts array-like x and y arguments into numpy arrays and stores as self.x and self.y. However, it passes the original arrays to _qhull.delaunay, which converts again as part of pybind11 bridging.
Instead, pass the numpy arrays.
AI Disclosure
None used for this specific fix. Found while working on #32411 where I did use AI.
PR quality check