Repository navigation
Remove print() from test_agg_filter_alpha - #32439
timhoffm merged 2 commits into
Conversation
Sorry, something went wrong.
story645
left a comment
There was a problem hiding this comment.
Though should that print statement get replaced with a test that the function is called? I think wrapping it in a mock will allow that?
Sorry, something went wrong.
|
Added! Note that I had to also add an explicit call to ax.figure.canvas.draw() to force it to draw immediately inside the function body (and not after for the @image_comparison). |
Sorry, something went wrong.
story645
left a comment
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
|
The windows test hung which I think caused the apparent coverage drop. Restarted the windows test, anyone can merge if tests are green. |
Sorry, something went wrong.
|
Coverage is passing now, but the Appveyor build is failing with: |
Sorry, something went wrong.
|
I've seen the import error also on other PRs. It's not related to this PR. |
Sorry, something went wrong.
* Remove print() from test * Add mock to ensure manual_alpha called
…439-on-v3.11.x Backport PR #32439 on branch v3.11.x (Remove print() from test_agg_filter_alpha)
PR summary
Remove a print() statement from a test.
AI Disclosure
None used
PR quality check