FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

RISC-V needs more time for testsuite and has problems with NaN by hrw · Pull Request #32446 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

RISC-V needs more time for testsuite and has problems with NaN #32446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hrw wants to merge 3 commits into
base: main
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
+4 −3
Conversation 4 Commits 3 Checks 36 Files changed 3
Open

RISC-V needs more time for testsuite and has problems with NaN #32446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7bef015
Fix AsinhLocator invalid value warning in np.floor on riscv64
hrw Oct 2, 2026
cfaed8c
Increase subprocess test timeout for slow architectures
hrw Oct 2, 2026
367c3f5
Apply CI timeout multiplier to interactive backend tests
hrw Oct 7, 2026
File filter

Filter by extension

Filter by extension .py  (3) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 1 addition & 1 deletion lib/matplotlib/testing/__init__.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def setup():
set_reproducibility_for_testing()


def subprocess_run_for_testing(command, env=None, timeout=60, stdout=None,
def subprocess_run_for_testing(command, env=None, timeout=300, stdout=None,

tacaswell Oct 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can we make this conditional on architecture? The shorter timeout is nicer when working locally so it fails faster if it has failed on arm/x86_64

hrw Oct 7, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

There is "if ci environment" thing which bumps timeouts by 6.

This place does not use it so it got patched this way.

May take a look to adapt it next week.
stderr=None, check=False, text=True,
capture_output=False, **kwargs):
"""
Expand Down
2 changes: 1 addition & 1 deletion lib/matplotlib/tests/test_backends_interactive.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def _get_testable_interactive_backends():

# Reasonable safe values for slower CI/Remote and local architectures; timeouts may be
# automatically increased later by subprocess_run_helper.
_test_timeout = 20
_test_timeout = 120 if is_ci_environment() else 20
_retry_count = 3 if is_ci_environment() else 0


Expand Down
3 changes: 2 additions & 1 deletion lib/matplotlib/ticker.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -2890,7 +2890,8 @@ def tick_values(self, vmin, vmax):

# Round the data-space values to be intuitive base-n numbers, keeping track of
# positive and negative values separately and carefully treating the zero value.
with np.errstate(divide="ignore"): # base ** log(0) = base ** -inf = 0.
# base ** log(0) = base ** -inf = 0.
with np.errstate(divide="ignore", invalid="ignore"):
if self.base > 1:
pows = (np.sign(xs)
* self.base ** np.floor(np.log(abs(xs)) / math.log(self.base)))
Expand Down
Loading
Back | FazBrowse Home | New Git URL