FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update dates.py by MaddipatlaChetan24 · Pull Request #32498 · matplotlib/matplotlib · GitHub

Repository navigation

Update dates.py - #32498

Open
MaddipatlaChetan24 wants to merge 2 commits into
matplotlib:mainfrom
MaddipatlaChetan24:patch-2
Open

MaddipatlaChetan24 wants to merge 2 commits into
matplotlib:mainfrom
MaddipatlaChetan24:patch-2

Conversation

MaddipatlaChetan24 commented Oct 17, 2026 •
edited
Loading

Copy link
Copy Markdown

PR summary

drange() promises a half-open interval [dstart, dend), but when the requested span is an exact multiple of delta, floating-point error in date2num()'s day conversion can push the computed step count one too high. The existing single if correction only backs off by one step, which isn't enough in this case, so the last returned point lands exactly on dend instead of before it. Changed the single if to a while loop so it absorbs any amount of overshoot, not just one step. Added a regression test for the exact-multiple boundary case.

PR quality check

  • Use an expressive title, e.g. "Fix title font property precedence"
  • New and changed code is tested
  • Plotting related features are demonstrated in an example
  • New features and API changes have release notes
  • Documentation complies with general and docstring guidelines

Copy link
Copy Markdown

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks. We also ask that you please finish addressing any review comments on this PR and wait for it to be merged (or closed) before opening a new one, as it can be a valuable learning experience to go through the review process.

You can also join us on discourse chat for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide.
Please let us know if (and how) you use AI, it will help us give you better feedback on your PR.

We strive to be a welcoming and open project. Please follow our Code of Conduct.

github-actions Bot added first-contribution topic: date handling AgentScan: automated AgentScan classified an account as automated. and removed first-contribution labels Oct 17, 2026

rcomer commented Oct 17, 2026

Copy link
Copy Markdown
Member

This PR shows indications of having been generated by AI, including the flag by AgentScan. Please check it against our policy and, if it complies, update the PR summary to use our template. This should including the AI disclosure and the PR quality checklist. At the moment the boxes that have been checked do not match what has actually been done. Neither is there an added regression test as stated in the summary.
https://matplotlib.org/devdocs/devel/contribute.html#use-of-generative-ai

rcomer added the status: autoclose candidate PRs that are not yet ready for review and may be automatically closed in two weeks label Oct 17, 2026

Copy link
Copy Markdown

⏰ This pull request might be automatically closed in two weeks from now.

Thank you for your contribution to Matplotlib and for the effort you have put into this PR. This pull request does not yet meet the quality and clarity standards needed for an effective review. Project maintainers have limited time for code reviews, and our goal is to prioritize well-prepared contributions to keep Matplotlib maintainable.

Matplotlib maintainers cannot provide one-to-one guidance on this PR. However, if you ask focused, well-researched questions, a community member may be willing to help. 💬

To increase the chance of a productive review:

As the author, you are responsible for driving this PR, which entails doing necessary background research as well as presenting its context and your thought process. If you are a new contributor, or do not know how to fulfill these requirements, we recommend that you familiarize yourself with Matplotlib's development conventions or engage with the community via our Discourse or one of our meetings before submitting code.

If you substantially improve this PR within two weeks, leave a comment and a team member may remove the status: autoclose candidate label and the PR stays open. Cosmetic changes or incomplete fixes will not be sufficient. Maintainers will assess improvements on their own schedule. Please do not ping (@) maintainers.

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AgentScan: automated AgentScan classified an account as automated. status: autoclose candidate PRs that are not yet ready for review and may be automatically closed in two weeks topic: date handling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL