FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

add markerfacecolor to rcsetup.py by MC-Escherichia · Pull Request #3583 · matplotlib/matplotlib · GitHub

Repository navigation

add markerfacecolor to rcsetup.py - #3583

Closed
MC-Escherichia wants to merge 1 commit into
matplotlib:masterfrom
MC-Escherichia:issue3293b
Closed

MC-Escherichia wants to merge 1 commit into
matplotlib:masterfrom
MC-Escherichia:issue3293b

Conversation

Copy link
Copy Markdown

closes #3293

This is the simplest fix, I didn't think to check to see if any other variables are missing from rcsetup.py

Copy link
Copy Markdown
Member

This needs to be added to the template rcparam file, everyplace that uses linestyle needs to check this rcparam, and it needs to be documented in whats_new.

tacaswell added this to the v1.5.x milestone Sep 28, 2014

Copy link
Copy Markdown
Author

Thanks for the tip, will look at it later this week.

Copy link
Copy Markdown
Member

@MC-Escherichia Have you had time to look at this again?

Copy link
Copy Markdown
Author

I've looked at at it, but I am confused by what you mean that "everyplace that uses [[linestyle]] needs to check this rcparam", er well I keep meaning to ask about the best way to check everyplace?

Copy link
Copy Markdown
Member

As this is a new rcparam, no code actual use this as a default. Every place that you would want to be able to control the market face color you need to add logic to check that the user did not explicitly pass in a value which needs to be respected and then use this value.

I think this is further complicated because there is some logic to use color for the face color if it is not specified so this should be careful not to interfere with that (ex during color cycling).

tacaswell modified the milestones: proposed next point release, next point release Feb 19, 2015
tacaswell modified the milestones: proposed next point release, next point release Jun 23, 2015

Copy link
Copy Markdown
Member

Closing due to inactivity.

tacaswell closed this Mar 22, 2016
QuLogic modified the milestones: unassigned, 2.1 (next point release) Mar 22, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

markerfacecolor / mfc not in rcparams

3 participants


Back | FazBrowse Home | New Git URL