FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixes bug 3165422: color cycles even if kwarg 'color' is set by faucon · Pull Request #41 · matplotlib/matplotlib · GitHub

Repository navigation

Fixes bug 3165422: color cycles even if kwarg 'color' is set - #41

Merged
efiring merged 1 commit into
matplotlib:masterfrom
faucon:colorcycle
Mar 23, 2011
Merged

efiring merged 1 commit into
matplotlib:masterfrom
faucon:colorcycle

Conversation

faucon commented Mar 10, 2011

Copy link
Copy Markdown
Contributor

Hi there,
i send a patch to matplotlib-devel last week. As there was no reaction, i now send it again as an pull request.

-maximilian

efiring commented Mar 10, 2011

Copy link
Copy Markdown
Member

Looks reasonable to me. One might raise the question of whether markerfacecolor etc kwargs should be checked along with the color kwarg. The problem with doing that, though, is that someone might want to specify markeredgecolor with a kwarg, while letting marker face colors cycle. That suggests that restricting the check to the "color" kwarg is OK.

Copy link
Copy Markdown
Member

I think this patch is reasonable. And I agree that this should only be focused on 'color'. If we want to cycle markeredgecolor, we can address that separately.

efiring commented Mar 10, 2011

Copy link
Copy Markdown
Member

It is not a question of wanting to cycle markeredgecolor, but rather of detecting when a user doesn't want the cycle to be advanced. Still, at this point, going with the patch seems reasonable. I don't have time for it right now; if you do, go ahead and merge it.

efiring merged commit 531b7cc into matplotlib:master Mar 23, 2011
richbwood mentioned this pull request Dec 19, 2012
magnunor pushed a commit to magnunor/matplotlib that referenced this pull request Dec 5, 2013
BUG-FIX: fixes matplotlib#41 by using mahotas if available
ENHANCE: new parameter only_view to save only the current view
ENHANCE: before proceeding to rescale it first check if it makes sense
fariza added a commit to fariza/matplotlib that referenced this pull request Sep 22, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL