Repository navigation
backends: fix alpha handling for cairo and macosx - #437
Merged
efiring merged 1 commit intoAug 27, 2011
Merged
efiring merged 1 commit into
efiring merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
There are two parts to this change. First, the cairo and macosx backends recycle the graphics context instead of making a new one with the new_gc() method, so the _alpha attribute must be reset to 1 at that point. Second, the GraphicsContextBase.set_foreground() method needs to call the set_alpha method instead of setting the _alpha attribute, so that the subclass method is called.
efiring
added a commit
that referenced
this pull request
Aug 27, 2011
backends: fix alpha handling for cairo and macosx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two parts to this change. First, the cairo
and macosx backends recycle the graphics context instead
of making a new one with the new_gc() method, so the _alpha
attribute must be reset to 1 at that point. Second, the
GraphicsContextBase.set_foreground() method needs to call
the set_alpha method instead of setting the _alpha attribute,
so that the subclass method is called.