FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

API: remove agg path chunking logic by tacaswell · Pull Request #4464 · matplotlib/matplotlib · GitHub

Repository navigation

API: remove agg path chunking logic - #4464

Closed
tacaswell wants to merge 1 commit into
matplotlib:masterfrom
tacaswell:api_remove_chunking
Closed

tacaswell wants to merge 1 commit into
matplotlib:masterfrom
tacaswell:api_remove_chunking

Conversation

Copy link
Copy Markdown
Member

Removes experimental feature added in 2008 and never enabled by
default.

Closes #4404

attn @efiring

Removes experimental feature added in 2008 and never enabled by
default.

Closes matplotlib#4404

efiring commented May 24, 2015

Copy link
Copy Markdown
Member

Good catch--I forgot all about this. Path simplification doesn't supersede this, however. It can still make the difference between being able make a plot, and not. Here is an example:

import numpy as np
import matplotlib.pyplot as plt
xx = np.random.randn(1000000)
yy = np.ma.array(xx)
yy[::3] = np.ma.masked
plt.plot(yy)  # fails
plt.rcParams['agg.path.chunksize'] = 20000
plt.plot(yy) # succeeds

Maybe the thing to do, in the interest of simplification, is to remove the rcParam and hardwire a suitable chunksize. @mdboom, is there a better way of avoiding the agg limitation?

tacaswell added this to the proposed next point release milestone May 24, 2015
tacaswell added API: changes Changes to the public API, typically requiring deprecation. status: needs revision and removed status: needs review labels May 24, 2015

Copy link
Copy Markdown
Member Author

Ah, sorry I misunderstood your comment.

mdboom commented May 26, 2015

Copy link
Copy Markdown
Member

@efiring: No -- unfortunately, the limit is a compile-time constant in Agg.

QuLogic commented Apr 30, 2017

Copy link
Copy Markdown
Member

There's a test case for the chunking in #8176, so it does seem to work; is its non-use the only reason for removing it?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API: changes Changes to the public API, typically requiring deprecation. status: needs revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatically setting agg.path.chunksize?

4 participants


Back | FazBrowse Home | New Git URL