| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Btw I think issue #4732 should be addressed first. |
Sorry, something went wrong.
Sorry, something went wrong.
|
@mdehoon Have you had a chance to look at the updated text? |
Sorry, something went wrong.
There was a problem hiding this comment.
Maybe add the reference: "For further details see: http://www.amazon.com/Interactive-Applications-using-Matplotlib-Benjamin/dp/1783988843?"
Sorry, something went wrong.
There was a problem hiding this comment.
(sp)
Sorry, something went wrong.
|
I'm not going to let this hold up 1.5.0 -- as it's doc only, it's low cost to just put it in 1.5.1. |
Sorry, something went wrong.
|
I don't think this is required to be on 2.0. |
Sorry, something went wrong.
|
@QuLogic I think I got all of your comments |
Sorry, something went wrong.
There was a problem hiding this comment.
Is this still WIP?
Sorry, something went wrong.
|
In principle this is good to go, but I am not a great writer... |
Sorry, something went wrong.
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
| :template: autosummary.rst | ||
| :nosignatures: | ||
|
|
||
| pyplot.show |
There was a problem hiding this comment.
Was there a reason for having these two separately from the above?
Sorry, something went wrong.
There was a problem hiding this comment.
I was trying to group ion, ioff, isinteractive as a "family" that queries and modifies the state of interactive mode and these two as a "family" that may run the GUI event loop. I'm not sure if it works as well in practice as it does in my head.
Sorry, something went wrong.
There was a problem hiding this comment.
It's a logical distinction; is it worth preceding each group with a concise statement of what makes it a family?
Sorry, something went wrong.
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
There was a problem hiding this comment.
I suppose we can leave this till Monday or whenever we tag 3.3 rc.
Sorry, something went wrong.
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
There was a problem hiding this comment.
Partial review so far--I haven't looked beyond interactive.rst. Thank you for moving this forward. It doesn't have to be perfect to be merged; it's a big step in the right direction.
Sorry, something went wrong.
| :template: autosummary.rst | ||
| :nosignatures: | ||
|
|
||
| pyplot.show |
There was a problem hiding this comment.
It's a logical distinction; is it worth preceding each group with a concise statement of what makes it a family?
Sorry, something went wrong.
| If you are in non-interactive mode (or created figures while in | ||
| non-interactive mode) you may need to explicitly call `.pyplot.show` | ||
| to bring the windows onto your screen. If you only want to run the | ||
| GUI event loop for a fixed amount of time you can use `.pyplot.pause`. |
There was a problem hiding this comment.
-> "GUI event loop and block for a fixed amount of time..." In the typical (I suspect) use case, the key desired behavior is the blocking, not the interactivity via the GUI event loop.
Sorry, something went wrong.
| integrated with your command prompt. If you have the GUI event loop | ||
| integrated with your prompt, then shown figures will be "live" while | ||
| the prompt is waiting for input, if it is not integrated then your | ||
| figures will only be "live" when the GUI event loop is running (via |
There was a problem hiding this comment.
This is confusing to me. Where does "interactive mode" fit into this second part of the paragraph? Maybe the missing point is that in "interactive mode" but without ipython magic, when working at the command line, the figure will be updated on the screen with each command, but it will not respond to mouse actions or keystrokes; for that, one needs the magic.
Sorry, something went wrong.
There was a problem hiding this comment.
At least PyQt and tkinter have ship with hooks that integrate with the readline implementation of the "plain" Python prompt. The IPython magic is the easiest way but not the only way.
Sorry, something went wrong.
| Close Figure :rc:`keymap.quit` | ||
| Constrain pan/zoom to x axis hold **x** when panning/zooming with mouse | ||
| Constrain pan/zoom to y axis hold **y** when panning/zooming with mouse | ||
| Preserve aspect ratio hold **CONTROL** when panning/zooming with mouse |
There was a problem hiding this comment.
This is needed only for zooming, I think; panning never changes the aspect ratio.
Sorry, something went wrong.
There was a problem hiding this comment.
right-click pan will change the view limits and respect this.
Sorry, something went wrong.
There was a problem hiding this comment.
I've never heard of right-click pan before, as far as I know. Maybe I've never stumbled over it because I use the Mac trackpad rather than a mouse.
Sorry, something went wrong.
There was a problem hiding this comment.
right-click zoom zooms out (by putting the current view limits to be where the box you drew was)
Sorry, something went wrong.
There was a problem hiding this comment.
A couple small typos.
Sorry, something went wrong.
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
|
I don't know if it's old, or too large, or what, but I had to try 3 times to merge that... |
Sorry, something went wrong.
In bb8058a via matplotlib#4779 I accidentally deleted the (illustrated) section on what the buttons on the default toolbar do. I suspect that this was a bad rebase as I do not think I would have intentionally deleted this content. This commit: - restores the content as-was: git checkout b49973a doc/users/navigation_toolbar.rst - fixes the paths to images (the files have moved around) - copy the navigation content into interactive.rst and re-remove navigation_toolbar.rst Partially addresses matplotlib#25266.
In bb8058a via matplotlib#4779 I accidentally deleted the (illustrated) section on what the buttons on the default toolbar do. I suspect that this was a bad rebase as I do not think I would have intentionally deleted this content. This commit: - restores the content as-was: git checkout b49973a doc/users/navigation_toolbar.rst - fixes the paths to images (the files have moved around) - copy the navigation content into interactive.rst and re-remove navigation_toolbar.rst Partially addresses matplotlib#25266.
| Back | FazBrowse Home | New Git URL |
This is still a work in progress (as there are still empty sections)
@mdehoon @WeatherGod Thoughts?