FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

mep12 on manual_axis.py by ericmjl · Pull Request #4884 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

mep12 on manual_axis.py - #4884

Merged
jenshnielsen merged 2 commits into
matplotlib:masterfrom
ericmjl:manual_axis.py_mep12
Aug 11, 2015
ConversationCommits (2)ChecksFiles changed
Merged

mep12 on manual_axis.py#4884
jenshnielsen merged 2 commits into
matplotlib:masterfrom
ericmjl:manual_axis.py_mep12

Conversation

ericmjl commented Aug 7, 2015

Copy link
Copy Markdown
Contributor

No description provided.

dopplershift added the MEP: MEP12 gallery and examples improvements label Aug 7, 2015
dopplershift reviewed Aug 7, 2015
View reviewed changes
Comment thread examples/pylab_examples/manual_axis.py Outdated

dopplershift Aug 7, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why comment out the line and not just remove?

ericmjl Aug 7, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Whoops! Going to remove it.

dopplershift commented Aug 7, 2015

Copy link
Copy Markdown
Contributor

Given the comment at the top of the file, I wonder if we should just do away with this one....

ericmjl commented Aug 7, 2015

Copy link
Copy Markdown
Contributor Author

Yeah, I was thinking so too... but I hesitated just to get others' input.

WeatherGod commented Aug 7, 2015

Copy link
Copy Markdown
Member

It belongs somewhere... but not here. It is way too advanced for a simple pylab/pyplot example.

ericmjl commented Aug 7, 2015

Copy link
Copy Markdown
Contributor Author

I will post this as an issue.

ericmjl mentioned this pull request Aug 7, 2015
Closed

jenshnielsen commented Aug 11, 2015

Copy link
Copy Markdown
Member

Since there now is an issue I will merge this

jenshnielsen added a commit that referenced this pull request Aug 11, 2015
Merge pull request #4884 from ericmjl/manual_axis.py_mep12
9e905ce 
mep12 on manual_axis.py
jenshnielsen merged commit 9e905ce into matplotlib:master Aug 11, 2015
ericmjl deleted the manual_axis.py_mep12 branch August 11, 2015 19:29
QuLogic added this to the v1.5.0 milestone Nov 4, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

MEP: MEP12 gallery and examples improvements

Projects

None yet

Milestone

v1.5.0

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL