Repository navigation
Qt5: Add flag that informs paintEvent if the agg buffer needs to updated, fix rubberband - #4962
pwuertz wants to merge 3 commits into
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
This should go in the init so it is always defined.
Sorry, something went wrong.
There was a problem hiding this comment.
It should, but this is seems to be a Mixin for which the init method is not called at all.
Sorry, something went wrong.
There was a problem hiding this comment.
Then we should fix that problem as well.
Sorry, something went wrong.
|
Added two new commits for fixing the rubberband in qt. The first adds a remove_rubberband() handler to backend_bases that is invoked when the zoom rectangle is released. The other commit changes the rubberband handling in the qt backend to utilize the rubberband removal handler. The previous solution was to simply remove the rectangle after each draw. This method fails when there is an additional paintEvent between two draw_rubberband() calls because it clears the rubberband while it is still being dragged (flicker). Also, there is the chance that the paintEvent requested by the last draw_rubberband() call before releasing the mouse might get delayed until after the draw_idle() call for zooming in. This causes the rubberband to be drawn on top of the zoomed-in figure (bad) and since there are no more events after the release the rubberband will stay on screen (worse). Also, changing the state of the rubberband doesn't trigger an agg buffer redraw anymore, freeing some CPU cycles while dragging. |
Sorry, something went wrong.
Added a flag for determining if paintEvent needs to update the agg buffer or not. The buffer is updated when draw_idle triggers the paintEvent and the buffer is considered valid after using draw and when using blit.
Discussion in #4943, Speed up Example in #4947