FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix #4854: set default numpoints of legend entries to 1 by gauteh · Pull Request #5131 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

fix #4854: set default numpoints of legend entries to 1 - #5131

Merged
tacaswell merged 2 commits into
matplotlib:masterfrom
gauteh:numpoints-1
Feb 8, 2016
ConversationCommits (2)ChecksFiles changed
Merged

fix #4854: set default numpoints of legend entries to 1#5131
tacaswell merged 2 commits into
matplotlib:masterfrom
gauteh:numpoints-1

Conversation

gauteh commented Sep 24, 2015

Copy link
Copy Markdown
Contributor

check #4854: set default numpoints to 1.

I am a bit unsure abouth wether classic.mplstyle should be changed.

jenshnielsen added the API: default changes Changes to default behavior label Sep 24, 2015

jenshnielsen commented Sep 24, 2015

Copy link
Copy Markdown
Member

The classic style should have numpoints=2, The idea of the classic style is to provide a style that exactly replicates how MPL looked before the default changes.

gauteh commented Sep 24, 2015

Copy link
Copy Markdown
Contributor Author

Also apparently the test-images must be updated when the PR is ready.

jenshnielsen commented Sep 24, 2015

Copy link
Copy Markdown
Member

No the tests run with the classic style as default to avoid having to update all the test images.

tacaswell added this to the next major release (2.0) milestone Sep 24, 2015

tacaswell commented Sep 24, 2015

Copy link
Copy Markdown
Member

Please don't merge this until we have pushed the 1.5 development off the master branch.

WeatherGod commented Sep 24, 2015

Copy link
Copy Markdown
Member

Hmmm, that is strange that only the legend_expand tests failed. Could that codepath be utilizing rcparams incorrectly?

QuLogic commented Dec 3, 2015

Copy link
Copy Markdown
Member

@gauteh Can you rebase? I believe something has corrected the failure on master.

tacaswell added a commit that referenced this pull request Feb 8, 2016
Merge pull request #5131 from gauteh/numpoints-1
d3a9782 
fix #4854: set default numpoints of legend entries to 1
tacaswell merged commit d3a9782 into matplotlib:master Feb 8, 2016

QuLogic commented Oct 16, 2016

Copy link
Copy Markdown
Member

Backported as part of #5774.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

API: default changes Changes to default behavior

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL