FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

TST: drop py2.6 & py3.3 testing by tacaswell · Pull Request #5215 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

TST: drop py2.6 & py3.3 testing - #5215

Merged
jenshnielsen merged 2 commits into
matplotlib:masterfrom
tacaswell:tst_drop_old_pythons
Oct 28, 2015
ConversationCommits (2)ChecksFiles changed
Merged

TST: drop py2.6 & py3.3 testing#5215
jenshnielsen merged 2 commits into
matplotlib:masterfrom
tacaswell:tst_drop_old_pythons

Conversation

tacaswell commented Oct 8, 2015

Copy link
Copy Markdown
Member

As discussed on the mailing list, going forward we will be dropping
support for python 2.6 and python 3.3.

This allows mpl to use ordered dicts and is required for in-progress
traitlet/serialization work.

  • moved minimum support numpy test to 2.7
  • moved pandas optional test dep to 3.5

http://matplotlib.1069221.n5.nabble.com/Matplotlib-devel-supported-python-versions-tt46154.html

tacaswell added this to the proposed next point release (2.1) milestone Oct 8, 2015

tacaswell commented Oct 8, 2015

Copy link
Copy Markdown
Member Author

This is a pre-req for getting #4762 merged.

tacaswell commented Oct 8, 2015

Copy link
Copy Markdown
Member Author

@matthew-brett @blink1073 Who do I ask nicely to get a pandas 3.5 wheel built?

blink1073 commented Oct 8, 2015

Copy link
Copy Markdown
Member

On it.

blink1073 commented Oct 8, 2015

Copy link
Copy Markdown
Member

Now available.

tacaswell commented Oct 8, 2015

Copy link
Copy Markdown
Member Author

If this passes I will squash these to 1 or 2 commits.

tacaswell commented Oct 8, 2015

Copy link
Copy Markdown
Member Author

Thanks!

On Thu, Oct 8, 2015 at 4:08 PM Steven Silvester notifications@github.com
wrote:

Now available.

—
Reply to this email directly or view it on GitHub
#5215 (comment)
.

TST: drop py2.6 & py3.3 testing
254e169 
As discussed on the mailing list, going forward we will be dropping
support for python 2.6 and python 3.3.

This allows mpl to use ordered dicts and is required for in-progress
traitlet/serialization work.

 - moved minimum support numpy test to 2.7
 - moved pandas optional test dep to 3.5

http://matplotlib.1069221.n5.nabble.com/Matplotlib-devel-supported-python-versions-tt46154.html
BLD: updated classifiers
5beb7ab
tacaswell force-pushed the tst_drop_old_pythons branch from 7c06e9e to 5beb7ab Compare October 8, 2015 21:21
jkseppan reviewed Oct 9, 2015
View reviewed changes
Comment thread .travis.yml

jkseppan Oct 9, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Are there any plans to drop support for numpy 1.6? I think version 1.7 came out in early 2013, and supporting 1.6 seems to accumulate some preprocessor cruft.

tacaswell Oct 9, 2015

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We should ask the numpy folks how many versions back they are supporting bug fixes for and don't go further back than that.

I am 👍 on dropping old versions of numpy, but that should be a separate discussion.

jkseppan commented Oct 25, 2015

Copy link
Copy Markdown
Member

Also a prerequisite for #5295. I'm 👍 on merging this.

This is marked for the 2.1 milestone, but if I understood the mailing list post correctly, we'll be dropping official support for Python 2.6 in 2.0, so I think it makes sense to stop testing with 2.6 already in 2.0.

mdboom commented Oct 26, 2015

Copy link
Copy Markdown
Member

I'd want confirmation from @tacaswell that our understanding is correct that we'll drop Python 2.6 for matplotlib 2.0. It would be nice, because now we have a dependency that "new styles" --> depends on --> "new fonts" --> depends on --> "fixing font file caching" --> depends on --> "lru_cache which hasn't been backported to 2.6". So it will be hard to disentangle removing Python 2.6 support.

tacaswell modified the milestones: next major release (2.0), proposed next point release (2.1) Oct 26, 2015

tacaswell commented Oct 26, 2015

Copy link
Copy Markdown
Member Author

I think the net result of the mailing list discussion was that we are going to drop 'official' support for 2.6 in 1.5 as we do not want commit to releasing a 2.6 compatible bug fix 1.5.1. No one volunteered to manage that and no one said that 2.6 is critical to them.

We should probably back-port this to the 1.5.x branch as soon as we make it as well.

mdboom commented Oct 26, 2015

Copy link
Copy Markdown
Member

Sure. Let's release 1.5.0 final and then immediately merge this and backport it to 1.5.x.

This was referenced Oct 27, 2015
Merged
Merged

tacaswell commented Oct 28, 2015

Copy link
Copy Markdown
Member Author

This is blocking other PRs, might as well merge this now. I don't think we will have issues remembering to backport it tomorrow 👿

jenshnielsen added a commit that referenced this pull request Oct 28, 2015
Merge pull request #5215 from tacaswell/tst_drop_old_pythons
84afab1 
TST: drop py2.6 & py3.3 testing
jenshnielsen merged commit 84afab1 into matplotlib:master Oct 28, 2015
tacaswell deleted the tst_drop_old_pythons branch October 28, 2015 14:45

mdboom commented Oct 28, 2015

Copy link
Copy Markdown
Member

👏

mdboom commented Oct 30, 2015

Copy link
Copy Markdown
Member

Backported to v2.0.x as 1b243ed

jenshnielsen added a commit that referenced this pull request Oct 30, 2015
Merge pull request #5215 from tacaswell/tst_drop_old_pythons
1b243ed 
TST: drop py2.6 & py3.3 testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL