FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use facecolor instead of axisbg/axis_bgcolor by mdboom · Pull Request #5501 · matplotlib/matplotlib · GitHub

Repository navigation

Use facecolor instead of axisbg/axis_bgcolor - #5501

Merged
pelson merged 5 commits into
matplotlib:masterfrom
mdboom:axisbg
Nov 23, 2015
Merged

pelson merged 5 commits into
matplotlib:masterfrom
mdboom:axisbg

Conversation

mdboom commented Nov 17, 2015

Copy link
Copy Markdown
Member

Partial fix for #5309 (the second bullet point).

This deprecates axisbg and axis_bgcolor (which are axis-specific properties) in favor of facecolor.

mdboom added this to the next major release (2.0) milestone Nov 17, 2015

mdboom commented Nov 20, 2015

Copy link
Copy Markdown
Member Author

Coveralls decreasing because of the creation of deprecated functions. Other than that, I think this is good to go.

Copy link
Copy Markdown
Member

Add a test which checks the warnings come out? We don't do that all the time, but we probably should...

mdboom commented Nov 23, 2015

Copy link
Copy Markdown
Member Author

Test added.

pelson added a commit that referenced this pull request Nov 23, 2015
Use facecolor instead of axisbg/axis_bgcolor
pelson merged commit 8da435d into matplotlib:master Nov 23, 2015
mdboom pushed a commit to mdboom/matplotlib that referenced this pull request Dec 11, 2015
Use facecolor instead of axisbg/axis_bgcolor

mdboom commented Dec 11, 2015

Copy link
Copy Markdown
Member Author

Backported to 2.0 as 5f1127c

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL