Repository navigation
Fix sliders - #581
Closed
mdboom wants to merge 2 commits into
Closed
Fix sliders#581mdboom wants to merge 2 commits into
mdboom wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…ce it doesn't circumvent the Polygon.set_closed method. axhspan and axvspan should have been declared closed all along.
Copy link
Copy Markdown
Member
Author
|
Ok. I think the next thing to do is decide whether this or #576 makes more sense. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
While this fixes the slider demo, #576 addresses two more issues:
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #576 that should have fewer side effects since it doesn't circumvent the Polygon.set_closed method. axhspan and axvspan should have been declared closed all along.