FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix sliders by mdboom · Pull Request #581 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Fix sliders #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mdboom wants to merge 2 commits into from
Conversation 2 Commits 2 Checks 0 Files changed
Closed

Fix sliders #581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71e4105
Alternative to #576 that should have fewer side effects since it does…
mdboom Nov 10, 2011
d45ecfb
Fixes some problems with the previous commit pointed out by cgohlke.
mdboom Nov 11, 2011
File filter

Filter by extension

Filter by extension .py  (3) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
4 changes: 2 additions & 2 deletions lib/matplotlib/axes.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -3488,7 +3488,7 @@ def axhspan(self, ymin, ymax, xmin=0, xmax=1, **kwargs):
ymin, ymax = self.convert_yunits( [ymin, ymax] )

verts = (xmin, ymin), (xmin, ymax), (xmax, ymax), (xmax, ymin)
p = mpatches.Polygon(verts, **kwargs)
p = mpatches.Polygon(verts, closed=True, **kwargs)
p.set_transform(trans)
p.x_isdata = False
self.add_patch(p)
Expand Down Expand Up @@ -3545,7 +3545,7 @@ def axvspan(self, xmin, xmax, ymin=0, ymax=1, **kwargs):
ymin, ymax = self.convert_yunits( [ymin, ymax] )

verts = [(xmin, ymin), (xmin, ymax), (xmax, ymax), (xmax, ymin)]
p = mpatches.Polygon(verts, **kwargs)
p = mpatches.Polygon(verts, closed=True, **kwargs)
p.set_transform(trans)
p.y_isdata = False
self.add_patch(p)
Expand Down
9 changes: 5 additions & 4 deletions lib/matplotlib/patches.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -778,14 +778,15 @@ def get_closed(self):

def set_closed(self, closed):
self._closed = closed
xy = self._get_xy()
new_xy = xy = self._get_xy()
if closed:
if len(xy) and (xy[0] != xy[-1]).any():
xy = np.concatenate([xy, [xy[0]]])
new_xy = np.concatenate([xy, [xy[0]]])
else:
if len(xy)>2 and (xy[0]==xy[-1]).all():
xy = xy[0:-1]
self._set_xy(xy)
new_xy = xy[0:-1]
if new_xy is not xy:
self._set_xy(new_xy)

def get_xy(self):
return self._path.vertices
Expand Down
4 changes: 2 additions & 2 deletions lib/matplotlib/widgets.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -317,8 +317,8 @@ def _update(self, event):

def set_val(self, val):
xy = self.poly.xy
xy[-1] = val, 0
xy[-2] = val, 1
xy[2] = val, 1
xy[3] = val, 0
self.poly.xy = xy
self.valtext.set_text(self.valfmt%val)
if self.drawon: self.ax.figure.canvas.draw()
Expand Down
Back | FazBrowse Home | New Git URL