FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix 3187521 - crash due to unescaped fontpaths by ivanov · Pull Request #59 · matplotlib/matplotlib · GitHub

Repository navigation

Fix 3187521 - crash due to unescaped fontpaths - #59

Closed
ivanov wants to merge 1 commit into
matplotlib:masterfrom
ivanov:fix-3187521
Closed

ivanov wants to merge 1 commit into
matplotlib:masterfrom
ivanov:fix-3187521

Conversation

ivanov commented Mar 26, 2011

Copy link
Copy Markdown
Member

Some paths were improperly being interpreted as a regular expression, leading to errors.

Copy link
Copy Markdown
Member

I don't see how calling repr fixes this - it'll just put some quotation marks around the directory name, right? The glob function used here doesn't call any Unix functions, it calls fnmatch which compiles the pattern to a regexp. What we need to do is call os.listdir on each directory and filter the results with fnmatch.filter("*.ttf") etc.

Or am I getting this wrong?

Copy link
Copy Markdown
Member

See pull request #60

mdboom commented Mar 28, 2011

Copy link
Copy Markdown
Member

Chose alternative in pull request #60 -- therefore closing this.

mdboom closed this Mar 28, 2011
richbwood mentioned this pull request Dec 19, 2012
magnunor pushed a commit to magnunor/matplotlib that referenced this pull request Dec 5, 2013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL