FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make @cleanup *really* support generative tests. by anntzer · Pull Request #6022 · matplotlib/matplotlib · GitHub

Repository navigation

Make @cleanup *really* support generative tests. - #6022

Merged
tacaswell merged 1 commit into
matplotlib:masterfrom
anntzer:cleanup-generative-tests-again
Feb 18, 2016
Merged

tacaswell merged 1 commit into
matplotlib:masterfrom
anntzer:cleanup-generative-tests-again

Conversation

anntzer commented Feb 18, 2016

Copy link
Copy Markdown
Contributor

Generative tests were still not run after #5809. If f is defined as def f(): yield, isgeneratorfunction(f) == isgenerator(f()) == True.

Copy link
Copy Markdown
Member

'power cycled' to re-trigger build against new master.

tacaswell added this to the 2.1 (next point release) milestone Feb 18, 2016
tacaswell added a commit that referenced this pull request Feb 18, 2016
tacaswell merged commit 236411c into matplotlib:master Feb 18, 2016

Copy link
Copy Markdown
Member

Merging as I do not think the close/open cycle restarts appveyor.

Copy link
Copy Markdown
Member

Does this need to be backported to 2.x?

QuLogic commented Feb 18, 2016

Copy link
Copy Markdown
Member

#5809 is actually milestoned to be on 1.5.2, though I'm not seeing it.

anntzer deleted the cleanup-generative-tests-again branch February 21, 2016 17:32

QuLogic commented Mar 26, 2016

Copy link
Copy Markdown
Member

This should be backported if we want to get #5785 into 2.x, no?

tacaswell added a commit that referenced this pull request Mar 26, 2016
tacaswell modified the milestones: 2.0 (style change major release), 2.1 (next point release) Mar 26, 2016

Copy link
Copy Markdown
Member

backported to v2.x as 0375ea4

@QuLogic Good catch on this

bearstrong pushed a commit to bearstrong/matplotlib that referenced this pull request Apr 1, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL