| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
|
||
| def __init__(self, *args, **kwargs): | ||
| # This must come first so the backend's owner is set correctly | ||
| TruetypeFonts.__init__(self, *args, **kwargs) |
There was a problem hiding this comment.
Is the comment above still true?
Sorry, something went wrong.
There was a problem hiding this comment.
Actually, I think it turned out that this move wasn't necessary after all -- I had meant to revert it before committing. I'll do so now.
Sorry, something went wrong.
|
Looks good to me! 👍 Do we have any idea why forcing an italics class was initially needed? Or was it just a bug? |
Sorry, something went wrong.
|
In the context of STIX falling back to Bakoma, it needs to be hardcoded to it because the symbols the fallback was needed for are only in it. I think this was copied-and-pasted to the context of DejaVu falling back to STIX, where that is not the case. |
Sorry, something went wrong.
|
Are there no italic numbers? 05 vs 15? I also wonder what is wrong with the baseline of the 't'. |
Sorry, something went wrong.
|
@QuLogic: That's correct. There are no italic circled numbers. Not sure what you mean by "05 vs. 15" The baseline of t is a larger issue (addressed by #5414, but it will be some time to get that done). But that's not introduced by this PR. |
Sorry, something went wrong.
No, I didn't mean circled, just plain italic numbers, e.g., mathfont_dejavusans_05.png vs. mathfont_dejavusans_15.png specify mathrm vs. mathit. But I see this is the case for the other fonts as well. |
Sorry, something went wrong.
|
Yes -- there are no italic numbers in any of these fonts. |
Sorry, something went wrong.
|
This is ready to merge. |
Sorry, something went wrong.
Fix #5998: Support fallback font correctly
| Back | FazBrowse Home | New Git URL |
Cc: @zblz