FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ENH: make antialiased gifs for Tk, and remove unused image files by efiring · Pull Request #6627 · matplotlib/matplotlib · GitHub

Repository navigation

ENH: make antialiased gifs for Tk, and remove unused image files - #6627

Merged
jenshnielsen merged 1 commit into
matplotlib:v2.xfrom
efiring:icon_antialias
Jun 23, 2016
Merged

jenshnielsen merged 1 commit into
matplotlib:v2.xfrom
efiring:icon_antialias

Conversation

efiring commented Jun 22, 2016

Copy link
Copy Markdown
Member

Closes #6610.

efiring added this to the 2.0 (style change major release) milestone Jun 22, 2016

QuLogic commented Jun 23, 2016

Copy link
Copy Markdown
Member

Why is it called hand.* when it's a cross in a circle? And where is that even used?

efiring commented Jun 23, 2016

Copy link
Copy Markdown
Member Author

Good question, and I don't know the answer. I think it might be the cursor for pan/zoom. Or maybe it is a fossil.

Copy link
Copy Markdown
Member

👍 I checked with tk and this does look much better

Copy link
Copy Markdown
Member

I did a quick look and I can not find any use of the hand icon (git grep hand[^l] returns only a few hits).

Looking at backend_tkagg the file 'move' has been used for panning as far back as the git history goes (shows up in e34a333) but the comments at https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/backend_bases.py#L2795 imply that hand used to used for panning. That comment also (with minor formatting changes) goes back to e34a333 .

99% sure that the whole hand set is a fossil that we can safely remove. There might be some third-party backends out there that use it?

Copy link
Copy Markdown
Member

I am in favor of merging this as-is and dealing with removing hand later.

Do we want to put in an API note for removing the xpm and ppm files?

efiring commented Jun 23, 2016

Copy link
Copy Markdown
Member Author

I see those files as internal implementation details, not API; they were never intended for use outside matplotlib.

efiring commented Jun 23, 2016

Copy link
Copy Markdown
Member Author

I see those files as internal implementation details, not API; they were never intended for use outside matplotlib, as far as I know.

jenshnielsen merged commit 11226f8 into matplotlib:v2.x Jun 23, 2016
efiring deleted the icon_antialias branch June 23, 2016 17:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL