Repository navigation
Fix Normalize(<signed integer array>). - #6837
Merged
tacaswell merged 2 commits intoAug 1, 2016
Merged
tacaswell merged 2 commits into
tacaswell merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Basically, everything needs to be cast to a float early enough.
Copy link
Copy Markdown
Member
|
Related to, but not part of this PR: process_value is not doing what it claims in the docstring--it is casting float32 to float64 instead of preserving it. Only 1-byte and 2-byte integers get cast to float32. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Actually that was also broken by #6700. I fixed it now. |
Sorry, something went wrong.
anntzer
force-pushed
the
fix-integer-normalization
branch
from
1ec7c42 to
9d6f77e
Compare
July 27, 2016 01:31
anntzer
force-pushed
the
fix-integer-normalization
branch
from
9d6f77e to
ac0c85a
Compare
July 27, 2016 02:26
tacaswell
added a commit
that referenced
this pull request
Aug 1, 2016
FIX: Normalize(<signed integer array>). closes #6825
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically, everything needs to be cast to a float early enough.
See #6825, #6700 -- I've decided to use the whack-a-bug-at-a-time approach for now.