FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tuples don't have a pop() method. The same change has been made upstream... by pmav99 · Pull Request #693 · matplotlib/matplotlib · GitHub

Repository navigation

tuples don't have a pop() method. The same change has been made upstream... - #693

Closed
pmav99 wants to merge 1 commit into
matplotlib:masterfrom
pmav99:patch-1
Closed

pmav99 wants to merge 1 commit into
matplotlib:masterfrom
pmav99:patch-1

Conversation

pmav99 commented Feb 1, 2012

Copy link
Copy Markdown

mdboom commented Feb 1, 2012

Copy link
Copy Markdown
Member

+1. Can you rebase this on v1.1.x maintenance -- the bug appears to exist there, too.

pmav99 commented Feb 2, 2012

Copy link
Copy Markdown
Author

Sorry but I am not a git user, and I can't work out how I should do that. For good or for bad I have erased the patch-1 branch. Currently I have 2 commits on my fork. One on master and one on v1.1.x (I cherry picked the commit from master to v1.1.x so they are the same).

It seems that I can't add more commits on this pull request. And when I try to make a new pull request I can't find how I can add commits from two different branches. Could you provide some guidance?

ps. The time I spent on this is disproportionally large for something so trivial. Perhaps it would be easier if you just took the time to make the change and push it...

mdboom closed this Feb 3, 2012

mdboom commented Feb 3, 2012

Copy link
Copy Markdown
Member

Closed by 97c58d2

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL