FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

TST: Fixed `test_log_margins` test by Kojoley · Pull Request #7453 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

TST: Fixed test_log_margins test - #7453

Merged
efiring merged 1 commit into
matplotlib:masterfrom
Kojoley:fix-test_log_margins
Nov 13, 2016
ConversationCommits (1)ChecksFiles changed
Merged

TST: Fixed test_log_margins test#7453
efiring merged 1 commit into
matplotlib:masterfrom
Kojoley:fix-test_log_margins

Conversation

Kojoley commented Nov 13, 2016

Copy link
Copy Markdown
Member

Closes #7452

Kojoley added this to the 2.0.1 (next bug fix release) milestone Nov 13, 2016
dopplershift approved these changes Nov 13, 2016
View reviewed changes

dopplershift left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

efiring commented Nov 13, 2016

Copy link
Copy Markdown
Member

@Kojoley, peripheral note: the Travis failure was the pytest run, after 25 minutes; I've seen this failure more often than not. Is there anything that can be done about it?

efiring merged commit 8515322 into matplotlib:master Nov 13, 2016
efiring added a commit that referenced this pull request Nov 13, 2016
Merge pull request #7453 from Kojoley/fix-test_log_margins
e6f2222 
TST: Fixed `test_log_margins` test

efiring commented Nov 13, 2016

Copy link
Copy Markdown
Member

back-ported to v2.x as e6f2222

Kojoley commented Nov 14, 2016 •
edited
Loading

Copy link
Copy Markdown
Member Author

@efiring I've seen this failure on both nose and pytest previously. Today I have run test_mixedsubplots about 500 times plus the whole test_mplot3d.py about 1500 times and it did not fail a single time. Unfortunately I do not have any idea what it could be and how to reproduce this failure. We have to grab a diff image from travis/appveyor at least to understand what is going on there,

QuLogic modified the milestones: 2.0.1 (next bug fix release), 2.0 (style change major release) Dec 7, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dopplershift dopplershift approved these changes

Assignees

No one assigned

Labels

topic: testing

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL