Repository navigation
BUG: make autoscale('tight') set margins to zero; closes #6968 - #7458
Merged
dopplershift merged 3 commits intoNov 14, 2016
Merged
dopplershift merged 3 commits into
dopplershift merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
tacaswell
approved these changes
Nov 14, 2016
NelleV
approved these changes
Nov 14, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the first commit of #7024 and keeps the second (the test), so it is an alternative.
The operative part is simply setting the Axes._xmargin and/or _ymargin to zero in autoscale('tight'). This is necessary to maintain behavior consistent with the docstring. The changes in autoscale_view are a description of the tight kwarg in the docstring, and a change in a large 'if' block to improve readability by putting the bail-out condition first, reducing indentation, and adding a comment. There is no functional change in autoscale_view.