Repository navigation
DOC: Remove explicit link to source file for Sphinx 1.5 compat. - #7629
Merged
tacaswell merged 1 commit intoDec 15, 2016
Merged
tacaswell merged 1 commit into
tacaswell merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Oops, I misread what it was looking for; with 1.5.1, it creates source as <fullname>.<ext>, but in previous versions it did <basename>.<ext>. We can configure <ext>, but as far as I can tell, not whether it uses the basename or the fullname. The faq/howto_faq.rst is the only explicit link to the sources we have; maybe we ought to just remove it? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
👍 to just remove the link. |
Sorry, something went wrong.
In Sphinx 1.5, the naming of the reST source files has changed, so it's not possible to make an explicit link that works across versions. And users can just follow the "Show Source" link mentioned in the text anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As this breaks linkchecker, I would like to self-merge to get Travis working again.