FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Minor tab colour fix by QuLogic · Pull Request #7847 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Minor tab colour fix - #7847

Merged
tacaswell merged 3 commits into
matplotlib:v2.xfrom
QuLogic:tab-colours
Jan 16, 2017
ConversationCommits (3)ChecksFiles changed
Merged

Minor tab colour fix#7847
tacaswell merged 3 commits into
matplotlib:v2.xfrom
QuLogic:tab-colours

Conversation

QuLogic commented Jan 16, 2017

Copy link
Copy Markdown
Member

Just a minor correction to the prefix in one last location. Also remove a redundant OrderedDict.

QuLogic added this to the 2.0 (style change major release) milestone Jan 16, 2017
tacaswell reviewed Jan 16, 2017
View reviewed changes
Comment thread lib/matplotlib/colors.py Outdated

cnames = CSS4_COLORS
COLOR_NAMES = {'xkcd': XKCD_COLORS, 'css4': CSS4_COLORS, 'tc': TABLEAU_COLORS}
COLOR_NAMES = {'xkcd': XKCD_COLORS, 'css4': CSS4_COLORS, 'tab': TABLEAU_COLORS}

tacaswell Jan 16, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This isn't used internally anymore and is not in any non-rc release. Do we just want to remove it?

QuLogic Jan 16, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think you're right; what was this for, anyway?

QuLogic Jan 16, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks like it was removed in #6382, but left for backwards-compatibility. Should we just remove tab here?

tacaswell Jan 16, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

but it went in from #5775

anntzer Jan 16, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

+1 for removing it if we can (but you probably could guess my vote).

QuLogic Jan 16, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ah, I see, I didn't look back far enough.

MNT: remove un-used public dictionary
3d3130a 
This dictionary was added in matplotlib#5775 sha: 9655f45 (and not yet released)
and was removed from internal use by matplotlib#6382 sha: (master) 22a7b95 / (2.x
backport) 3281bcd

tacaswell commented Jan 16, 2017

Copy link
Copy Markdown
Member

@QuLogic I took the liberty of just removing it.

NelleV changed the title Minor tab colour fix [MRG+2] Minor tab colour fix Jan 16, 2017
tacaswell merged commit f63ae7a into matplotlib:v2.x Jan 16, 2017
QuLogic deleted the tab-colours branch January 16, 2017 23:45
QuLogic changed the title [MRG+2] Minor tab colour fix Minor tab colour fix Jan 16, 2017
richeshgupta mentioned this pull request Sep 23, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anntzer anntzer left review comments
NelleV NelleV approved these changes
tacaswell tacaswell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL