FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update vlines example with axes wide lines. by bjodah · Pull Request #7878 · matplotlib/matplotlib · GitHub

Repository navigation

Update vlines example with axes wide lines. - #7878

Merged
QuLogic merged 2 commits into
matplotlib:masterfrom
bjodah:vline-hline-demo-transform-factory
Mar 9, 2017
Merged

QuLogic merged 2 commits into
matplotlib:masterfrom
bjodah:vline-hline-demo-transform-factory

Conversation

bjodah commented Jan 19, 2017

Copy link
Copy Markdown
Contributor

Add transform to vline example (as discussed [here]
(#5896 (comment)) )

@tacaswell was this what you had in mind?

codecov-io commented Jan 19, 2017 •
edited
Loading

Copy link
Copy Markdown

Current coverage is 62.16% (diff: 100%)

Merging #7878 into master will not change coverage

@@             master      #7878   diff @@
==========================================
  Files           174        174          
  Lines         56078      56078          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          34862      34862          
  Misses        21216      21216          
  Partials          0          0          

Powered by Codecov. Last update 4c5fca7...d353c71

anntzer commented Jan 20, 2017

Copy link
Copy Markdown
Contributor

Actually you can just do

ax.vlines(x, 0, 1, transform=ax.get_xaxis_transform())

which is quite simpler.

phobson commented Jan 20, 2017

Copy link
Copy Markdown
Member

In addition to what @anntzer said, would you mind making the example's docstring sphinx-gallery compatible?

Here's a PR that did just that for a few examples: https://github.com/matplotlib/matplotlib/pull/7331/files

The basic format for that is as follows:

"""
====================
Title of the example
====================

A more detailed description of the example. Discuss what
each subplot is demonstrating and talk about broader
concepts.
"""

import numpy as np
import matplotlib.pyplot as plt

# yada yada yada

############################################################################
# You can also include :math:`math` inline, or as separate equations:
#
# .. math::
#
#    \exp(j\pi) = -1

plt.show()

phobson added this to the 2.1 (next point release) milestone Jan 20, 2017

NelleV commented Jan 27, 2017

Copy link
Copy Markdown
Member

Hi @bjodah
Do you think you'd have time to finish up the minor comments on this PR? If you need help on anything, don't hesitate to ask.
N

NelleV commented Mar 8, 2017

Copy link
Copy Markdown
Member

I've added a small commit adding the docstring.

QuLogic commented Mar 9, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Build failure is unrelated PEP8 issues #8237.

QuLogic merged commit 3abe6e8 into matplotlib:master Mar 9, 2017
anntzer mentioned this pull request Mar 9, 2017
16 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL