FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ENH: Stricter validation of line style rcParams (and extended accepted types for `grid.linestyle`) by afvincent · Pull Request #8040 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

ENH: Stricter validation of line style rcParams (and extended accepted types for grid.linestyle) #8040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NelleV merged 15 commits into from
Feb 18, 2017
Conversation 32 Commits 15 Checks 0 Files changed
Merged

ENH: Stricter validation of line style rcParams (and extended accepted types for grid.linestyle) #8040

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
061061b
extend 'grid.linestyle' valid types to on-off ink sequences
afvincent Feb 7, 2017
5be29b5
extend 'add test for the new function 'validate_grid_linestyle'
afvincent Feb 7, 2017
25efd07
fix a small typo
afvincent Feb 8, 2017
5cb183c
Relax validation for all ls-related rcParams but contour.negative_lin…
afvincent Feb 9, 2017
d9ff6a8
Check that strings are valid line styles
afvincent Feb 9, 2017
44c3fde
fix PEP8
afvincent Feb 9, 2017
e8032df
use validate_linestyle even for rcParam 'contour.negative_linestyle'
afvincent Feb 10, 2017
2673585
Reintroduce former public validators for negative contours (but they …
afvincent Feb 13, 2017
7bd9bfe
make validate_linestyle private and case insensitive (+ adapt relevan…
afvincent Feb 13, 2017
ad21964
Remove deprecation warning in 'validate_negative_linestyle_legacy'
afvincent Feb 13, 2017
7ab75f5
Deprecate former validation schemes used by 'contour.negative_linestyle'
afvincent Feb 14, 2017
59328e6
Fix typo (a forgotten 'return' statement...)
afvincent Feb 14, 2017
70e87c8
Fix the deprecation decorators
afvincent Feb 17, 2017
c060842
Add a what's new entry
afvincent Feb 17, 2017
aabf385
Fix a typo with the example in the what's new entry
afvincent Feb 17, 2017
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
Prev Previous commit
Next Next commit
Deprecate former validation schemes used by 'contour.negative_linestyle'
  • Loading branch information
afvincent committed Feb 14, 2017
commit 7ab75f5eddf02007f90ff694a94ed19a9f1630e5
19 changes: 15 additions & 4 deletions lib/matplotlib/rcsetup.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
import warnings
import re

from matplotlib.cbook import mplDeprecation, ls_mapper
from matplotlib.cbook import mplDeprecation, deprecated, ls_mapper
from matplotlib.fontconfig_pattern import parse_fontconfig_pattern
from matplotlib.colors import is_color_like

Expand Down Expand Up @@ -530,11 +530,22 @@ def validate_ps_distiller(s):
'top', 'none'])
validate_fillstylelist = _listify_validator(validate_fillstyle)

validate_negative_linestyle = ValidateInStrings('negative_linestyle',
['solid', 'dashed'],
ignorecase=True)
_validate_negative_linestyle = ValidateInStrings('negative_linestyle',
['solid', 'dashed'],
ignorecase=True)


@deprecated('3.0.0?', pending=True,

NelleV Feb 16, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why can't we deprecate this "for sure"?

afvincent Feb 16, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

So, something like

@deprecated(the version number you will kindly suggest,  # :)
            addendum=(" See 'validate_negative_linestyle_legacy' " +
                      "deprecation warning for more information.")
            )

would be better?

NelleV Feb 17, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes :D
I suggest deprecating this in 2.1, which means no backporting. Is that a problem?
addendum=(" See 'validate_negative_linestyle_legacy' " +
"deprecation warning for more information."))
def validate_negative_linestyle(s):
_validate_negative_linestyle(s)


@deprecated('3.0.0?', pending=True,
addendum=(" The 'contour.negative_linestyle' rcParam now " +
"follows the same validation as the other rcParams " +
"that are related to line style."))
def validate_negative_linestyle_legacy(s):
try:
res = validate_negative_linestyle(s)
Expand Down
Back | FazBrowse Home | New Git URL