FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Clean up and move accented text example by dstansby · Pull Request #8065 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Clean up and move accented text example - #8065

Merged
QuLogic merged 5 commits into
matplotlib:masterfrom
dstansby:doc-accented-text
Feb 23, 2017
ConversationCommits (5)ChecksFiles changed
Merged

Clean up and move accented text example#8065
QuLogic merged 5 commits into
matplotlib:masterfrom
dstansby:doc-accented-text

Conversation

dstansby commented Feb 12, 2017

Copy link
Copy Markdown
Member

I thought I'd kick off the docathon by moving and cleaning the first example in pylab_examples.

QuLogic reviewed Feb 12, 2017
View reviewed changes
Comment thread examples/text_labels_and_annotations/accented_text.py Outdated
Using accented text in matplotlib
=================================

Matplotlib supports accented characters via TeX mathtext.

QuLogic Feb 12, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Also supported through regular Unicode characters, though that's not shown here.

tacaswell Feb 13, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I am 👍 on making this file utf-8 encoded and adding some accented characters.

anntzer Feb 16, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Perhaps merge it with unicode_demo.py then? See also #8083.

NelleV added this to the 2.1 (next point release) milestone Feb 16, 2017
NelleV approved these changes Feb 16, 2017
View reviewed changes

NelleV left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM 👍

NelleV changed the title Clean up and move accented text example [MRG+1] Clean up and move accented text example Feb 16, 2017
anntzer mentioned this pull request Feb 16, 2017
Closed
anntzer requested changes Feb 16, 2017
View reviewed changes

anntzer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

(marking a change request so that the option of merging with unicode_demo.py is more visible -- especially given the overlap with #8083. @dstansby feel free dismiss this review if you don't plan to do so, but then you get to take care of #8083 :-))

dstansby commented Feb 16, 2017

Copy link
Copy Markdown
Member Author

👍 done.

nb. I am just ignoring backend_driver for now, since one of my other PRs will get rid of needing to specify tests one by one and manually keeping track of them.

anntzer reviewed Feb 16, 2017
View reviewed changes
Comment thread examples/text_labels_and_annotations/accented_text.py Outdated
ax.set_title(r'$\ddot{o}\acute{e}\grave{e}\hat{O}'
r'\breve{i}\bar{A}\tilde{n}\vec{q}$', fontsize=20)

# Shorthand is also supported and curly's are optional

anntzer Feb 16, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

"curlies" perhaps?

anntzer Feb 20, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

attn @dstansby

phobson Feb 21, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

curly braces?

anntzer reviewed Feb 16, 2017
View reviewed changes
Comment thread examples/text_labels_and_annotations/accented_text.py Outdated
# Unicode demo
fig, ax = plt.subplots()
ax.set_title('Développés et fabriqués')
ax.set_xlabel("réactivité nous permettent d'être sélectionnés et adoptés")

anntzer Feb 16, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Actually both French sentences are meaningless. If we want to keep some foreign languages, I can propose

GISCARD CHAHUTÉ À L'ASSEMBLÉE
LE COUP DE DÉ DE DE GAULLE

(famous examples where keeping accents on caps is needed for the sentence to make any sense) :-)

tacaswell Feb 17, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Buffalo buffalo buffalo buffalo ?

anntzer Feb 17, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I guess English would benefit from diacritics too...

dstansby Feb 17, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the suggestions!

QuLogic merged commit a34c859 into matplotlib:master Feb 23, 2017
QuLogic changed the title [MRG+1] Clean up and move accented text example Clean up and move accented text example Feb 23, 2017
anntzer mentioned this pull request Feb 26, 2017
Closed
16 tasks done
dstansby deleted the doc-accented-text branch April 2, 2017 16:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tacaswell tacaswell left review comments
QuLogic QuLogic left review comments
phobson phobson left review comments
NelleV NelleV approved these changes
anntzer anntzer approved these changes

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

v2.1

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL