FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove example of matrix of size (12, 12) and (64, 64) by patniharshit · Pull Request #8094 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Remove example of matrix of size (12, 12) and (64, 64) - #8094

Merged
dstansby merged 2 commits into
matplotlib:masterfrom
patniharshit:keepmiddle
Feb 18, 2017
ConversationCommits (2)ChecksFiles changed
Merged

Remove example of matrix of size (12, 12) and (64, 64)#8094
dstansby merged 2 commits into
matplotlib:masterfrom
patniharshit:keepmiddle

Conversation

patniharshit commented Feb 17, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

refs #7956 Only keep middle plots
Remove first and third example and keep second one.

anntzer reviewed Feb 17, 2017
View reviewed changes
Comment thread examples/pylab_examples/matshow.py
@@ -10,17 +10,7 @@ def samplemat(dims):
aa[i, i] = i

anntzer Feb 17, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could be rewritten as np.fill_diagonal(aa, range(min(dims))).

dstansby Feb 17, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think the current version is much more readable, which is important for an example.

anntzer Feb 17, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm fine either way.

anntzer requested changes Feb 18, 2017
View reviewed changes

anntzer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Comment thread examples/pylab_examples/matshow.py Outdated
# Display a random matrix with a specified figure number and a grayscale
# colormap
plt.matshow(np.random.rand(64, 64), fignum=100, cmap=plt.cm.gray)
# Display matrix

anntzer Feb 18, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

two spaces, and trailing whitespace.

patniharshit Feb 18, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should I remove spaces ?

anntzer Feb 18, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

one before "matrix" and whatever is after.

tacaswell commented Feb 18, 2017

Copy link
Copy Markdown
Member

@anntzer I find your review confusing, you asked for changes with the comment 'LGTM' ;)

anntzer commented Feb 18, 2017

Copy link
Copy Markdown
Contributor

I noticed the spaces issue afterwards and forgot to edit the main message :-)

anntzer changed the title Remove example of matrix of size (12, 12) and (64, 64) [MRG+1] Remove example of matrix of size (12, 12) and (64, 64) Feb 18, 2017
dstansby approved these changes Feb 18, 2017
View reviewed changes

dstansby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

dstansby changed the title [MRG+1] Remove example of matrix of size (12, 12) and (64, 64) Remove example of matrix of size (12, 12) and (64, 64) Feb 18, 2017
dstansby merged commit 3b9a916 into matplotlib:master Feb 18, 2017
dstansby added this to the 2.0.1 (next bug fix release) milestone Feb 18, 2017
anntzer mentioned this pull request Feb 18, 2017
Closed
16 tasks done
dstansby added a commit that referenced this pull request Feb 18, 2017
Merge pull request #8094 from patniharshit/keepmiddle
35996ce 
Remove example of matrix of size (12, 12) and (64, 64)

dstansby commented Feb 18, 2017

Copy link
Copy Markdown
Member

Backported to 2.0.x via 35996ce

patniharshit deleted the keepmiddle branch February 19, 2017 14:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anntzer anntzer approved these changes
dstansby dstansby approved these changes

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

v2.0.1

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL