Repository navigation
Qt5: Fix event positions on HiDPI screens. - #8144
Merged
NelleV merged 1 commit intoMar 15, 2017
Merged
NelleV merged 1 commit into
NelleV merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
anntzer
requested changes
Feb 25, 2017
anntzer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
- Is it documented somewhere that fig.bbox.height is in physical pixels, not device-independent pixels? Should we try to change that?
- Either way, it'd be nice to add a docstring to the method to document this subtlety.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
figure.bbox.height comes from figsize * dpi and for hidpi, dpi is scaled up by whatever the ratio is so that the figure is rendered at high resolution. |
Sorry, something went wrong.
The event location is in logical pixels, which is the way it should stay for the rest of the stack.
QuLogic
force-pushed
the
qt5-hidpi-fixes
branch
from
0fe6178 to
419da79
Compare
February 26, 2017 02:15
Copy link
Copy Markdown
Member
Author
|
Added a comment about it in the docstring. |
Sorry, something went wrong.
anntzer
approved these changes
Feb 26, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The event location is in logical pixels, which is the way it should stay for the rest of the stack.
Fixes #8052.