FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

merge fill_demo and fill_demo_features by patniharshit · Pull Request #8154 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

merge fill_demo and fill_demo_features - #8154

Merged
NelleV merged 4 commits into
matplotlib:masterfrom
patniharshit:lineBarMarkerMerge
Mar 8, 2017
ConversationCommits (4)ChecksFiles changed
Merged

merge fill_demo and fill_demo_features#8154
NelleV merged 4 commits into
matplotlib:masterfrom
patniharshit:lineBarMarkerMerge

Conversation

patniharshit commented Feb 26, 2017

Copy link
Copy Markdown
Contributor

refs #7956

dstansby requested changes Feb 26, 2017
View reviewed changes
Comment thread examples/lines_bars_and_markers/fill_demo.py Outdated
@@ -1,13 +1,13 @@
import numpy as np
import matplotlib.pyplot as plt

dstansby Feb 26, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could the import lines be just below the title (as in the original file)? Otherwise this looks good if the tests pass!

dstansby changed the title merge fill_demo and fill_demo_features [MRG + 1] merge fill_demo and fill_demo_features Feb 26, 2017
dstansby added this to the 2.0.1 (next bug fix release) milestone Feb 26, 2017
QuLogic requested changes Feb 26, 2017
View reviewed changes
Comment thread examples/lines_bars_and_markers/fill_demo.py Outdated
plt.show()

"""
========================

QuLogic Feb 26, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You need to merge these two docstrings into something coherent at the beginning of the file. Just smooshing the separate files together is no good.

patniharshit Feb 27, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please review.
I was kinda sleepy, messed up commit message XD

Comment thread examples/lines_bars_and_markers/fill_demo.py Outdated
@@ -16,3 +16,22 @@
ax.fill(x, y, zorder=10)
ax.grid(True, zorder=5)
plt.show()

QuLogic Feb 26, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Remove; there's one at the end.

NelleV commented Mar 8, 2017

Copy link
Copy Markdown
Member

Thanks @patniharshit !

NelleV merged commit f032c51 into matplotlib:master Mar 8, 2017
patniharshit deleted the lineBarMarkerMerge branch March 8, 2017 07:20
QuLogic modified the milestones: 2.1 (next point release), 2.0.1 (next bug fix release) Mar 20, 2017
QuLogic changed the title [MRG + 1] merge fill_demo and fill_demo_features merge fill_demo and fill_demo_features Mar 20, 2017
anntzer mentioned this pull request Aug 31, 2017
Closed
16 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

QuLogic QuLogic requested changes
dstansby dstansby approved these changes

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

v2.1

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL