FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Addresses #8177, Readme badges by epintozzi · Pull Request #8178 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Addresses #8177, Readme badges - #8178

Merged
dstansby merged 4 commits into
matplotlib:masterfrom
epintozzi:readme_badges
Mar 2, 2017
ConversationCommits (4)ChecksFiles changed
Merged

Addresses #8177, Readme badges#8178
dstansby merged 4 commits into
matplotlib:masterfrom
epintozzi:readme_badges

Conversation

epintozzi commented Mar 2, 2017

Copy link
Copy Markdown
Contributor

Added badges for: Travis, Appveyor, Codecov, pypi, gitter, and depsy

anntzer commented Mar 2, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

I would suggest a plain text gitter link next to the mailing-list section.

You can also update the pypi link so that it points directly to pypi rather than via a redirection.

PS for whoever is reviewing this: you can check how it looks like at https://github.com/epintozzi/matplotlib/tree/readme_badges.

tacaswell added this to the 2.0.1 (next bug fix release) milestone Mar 2, 2017

tacaswell commented Mar 2, 2017

Copy link
Copy Markdown
Member

Can we be vain and not include codecov? 😈

Agree on including text link to gitter with the mailing lists

the 'view' button in the review page will also show you the rendering.

tacaswell reviewed Mar 2, 2017
View reviewed changes

tacaswell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Minor preference for a text link to gitter, but fine with this going in as-is.

Please backport to 2.0.0-doc

QuLogic mentioned this pull request Mar 2, 2017
Closed

dstansby commented Mar 2, 2017

Copy link
Copy Markdown
Member

I'll consider that a positive review @tacaswell, and merge!

dstansby merged commit 1f173dd into matplotlib:master Mar 2, 2017

dstansby commented Mar 2, 2017

Copy link
Copy Markdown
Member

This looks like your first contribution to Matplotlib @epintozzi, thanks a lot!

dstansby mentioned this pull request Mar 2, 2017
Closed
dstansby added a commit that referenced this pull request Mar 2, 2017
Merge pull request #8178 from epintozzi/readme_badges
6e52c51 
Addresses #8177, Readme badges

dstansby commented Mar 2, 2017

Copy link
Copy Markdown
Member

Backported to 2.0.0-doc via. 6e52c51

anntzer mentioned this pull request Mar 2, 2017
Closed
richeshgupta mentioned this pull request Sep 23, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tacaswell tacaswell left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.0.1

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL