FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

merged the tex_X.py files into a single file tex.py by helmiriawan · Pull Request #8199 · matplotlib/matplotlib · GitHub

Repository navigation

merged the tex_X.py files into a single file tex.py - #8199

Merged
QuLogic merged 3 commits into
matplotlib:masterfrom
delftswa2017:tex_gallery
May 29, 2017
Merged

QuLogic merged 3 commits into
matplotlib:masterfrom
delftswa2017:tex_gallery

Conversation

helmiriawan commented Mar 5, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR is to address issue #7956 .
Merged the two examples/pylab_examples/tex_X.py files into a single tex.py file.

Comment thread examples/pylab_examples/tex.py Outdated
plt.plot(t, s)

plt.xlabel(r'\textbf{time (s)}')
plt.ylabel('\\textit{Velocity (\u00B0/sec)}', fontsize=16)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Keep the named entity (\N{DEGREE SIGN} is much clearer...)

Comment thread examples/pylab_examples/tex.py Outdated



plt.figure(2, figsize=(6, 4))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you merge the two figures together? (e.g. two axes)

ax.plot(t, s)

ax.set_xlabel(r'\textbf{time (s)}')
ax.set_ylabel('\\textit{Velocity (\u00B0/sec)}')

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Same comment about unicode named entity.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I believe I have implemented it now 👍

Comment thread pytest.ini Outdated
*examples/pyplots/whats_new_99_axes_grid.py E225 E231 E302 E303
*examples/pyplots/whats_new_99_spines.py E231 E261
*examples/shapes_and_collections/artist_reference.py E203
*examples/text_labels_and_annotations/plot_tex.py E231

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I do not think we need this anymore

fig, ax = plt.subplots(figsize=(6, 4), tight_layout=True)
ax.plot(t, s)

ax.set_xlabel(r'\textbf{time (s)}')

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you add the fontsize and color kwargs back to a few of these?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why? The goal of this example is not to show how to use fontsize and color kwargs (and the change of fontsize and color doesn't make the plot look better).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

To avoid losing content due to the merge. It is worth showing that the font size and colors work with latex along with our internal text rendreing.

QuLogic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Typos and other corrections.

properly installed on your system. The first time you run a script
you will see a lot of output from tex and associated tools. The next
time, the run may be silent, as a lot of the information is cached in
~/.tex.cache

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't think we should mention the directory; it's an internal thing that can change, and I don't think this is even the right place on current systems.

Comment thread doc/users/usetex.rst Outdated

Note that display math mode (``$$ e=mc^2 $$``) is not supported, but adding the
command ``\displaystyle``, as in `tex_demo.py`, will produce the same
command ``\displaystyle``, as in `plo_tex.py`, will produce the same

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

plo -> plot

Comment thread doc/devel/documenting_mpl.rst Outdated
taken, these figures can be included in the usual way::

.. plot:: mpl_examples/pyplots/tex_unicode_demo.py
.. plot:: mpl_examples/text_lables_and_annotations/plot_tex.py

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lables -> labels

s = np.cos(4 * np.pi * t) + 2

t = np.arange(0.0, 1.0 + 0.01, 0.01)
s = np.cos(2*2*np.pi*t) + 2

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

These two lines just replaced the previous t and s; they also appear to do almost the same thing.

tacaswell added this to the 2.0.1 (next bug fix release) milestone Mar 12, 2017
QuLogic dismissed their stale review March 13, 2017 00:52

Corrections made.

QuLogic modified the milestones: 2.1 (next point release), 2.0.1 (next bug fix release) Mar 20, 2017
anntzer changed the title merged the tex_X.py files into a single file tex.py [MRG+1] merged the tex_X.py files into a single file tex.py Apr 16, 2017
Comment thread determinism_tex.svg Outdated
@@ -0,0 +1,29 @@
<?xml version="1.0" encoding="utf-8" standalone="no"?>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This file should not be added. Please rebase and remove it.

QuLogic dismissed their stale review May 29, 2017 00:37

Removed extra file.

QuLogic changed the title [MRG+1] merged the tex_X.py files into a single file tex.py merged the tex_X.py files into a single file tex.py May 29, 2017
QuLogic merged commit cc2c508 into matplotlib:master May 29, 2017

QuLogic commented May 29, 2017

Copy link
Copy Markdown
Member

I rebased the file out myself so we could merge this.

anntzer mentioned this pull request Aug 31, 2017
16 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL