FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Mep12 text labels and annotations by NelleV · Pull Request #8211 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Mep12 text labels and annotations - #8211

Merged
dstansby merged 4 commits into
matplotlib:masterfrom
NelleV:MEP12_text_labels_and_annotations
Mar 8, 2017
ConversationCommits (4)ChecksFiles changed
Merged

Mep12 text labels and annotations#8211
dstansby merged 4 commits into
matplotlib:masterfrom
NelleV:MEP12_text_labels_and_annotations

Conversation

NelleV commented Mar 7, 2017

Copy link
Copy Markdown
Member

Here are some more migrations of examples to compatible sphinx-gallery docstring.

refs #7206

NelleV changed the title Mep12 text labels and annotations [MRG] Mep12 text labels and annotations Mar 7, 2017
QuLogic requested changes Mar 7, 2017
View reviewed changes

QuLogic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

One typo.

Comment thread examples/text_labels_and_annotations/text_demo_fontdict.py Outdated
Controlling style of text and labels using a dictionary
=======================================================


QuLogic Mar 7, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Extra line.

Comment thread examples/text_labels_and_annotations/text_demo_fontdict.py Outdated


This example shows how to share parameters across many text objects and labels
by creating a dictionnaries of option passed across several functions.

QuLogic Mar 7, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

dictionnaries of option -> dictionary of options

NelleV commented Mar 7, 2017

Copy link
Copy Markdown
Member Author

Thanks for the review! I fixed the comments.

QuLogic reviewed Mar 7, 2017
View reviewed changes

QuLogic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Still one typo ;)

Comment thread examples/text_labels_and_annotations/text_demo_fontdict.py Outdated
=======================================================

This example shows how to share parameters across many text objects and labels
by creating a dictionnary of options passed across several functions.

QuLogic Mar 7, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

dictionnary ->dictionary

NelleV Mar 7, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

fixed again :)

QuLogic changed the title [MRG] Mep12 text labels and annotations [MRG+1] Mep12 text labels and annotations Mar 7, 2017
tacaswell added this to the 2.0.1 (next bug fix release) milestone Mar 7, 2017
anntzer requested changes Mar 7, 2017
View reviewed changes
Comment thread examples/text_labels_and_annotations/autowrap_demo.py Outdated

Matplotlib can wrap text automatically, but if it's too long, the text will be
displayed slightly outside of the boundaries of the axis anyways.

anntzer Mar 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A quick grep suggests that the common style in the codebase is an empty line after the closing quotes, not before.

Also applies below.

NelleV Mar 7, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We have common style code for documenting examples? And here I thought we didn't have documentation on examples :p

NelleV commented Mar 7, 2017

Copy link
Copy Markdown
Member Author

I've added/removed blank lines.

dstansby approved these changes Mar 7, 2017
View reviewed changes

dstansby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Will merge if the doc build on travis passes 👍

dstansby self-assigned this Mar 7, 2017

NelleV commented Mar 8, 2017

Copy link
Copy Markdown
Member Author

So… The documentation passes. The rest fails because it can't download freetype.

dstansby merged commit e88957d into matplotlib:master Mar 8, 2017
dstansby mentioned this pull request Mar 8, 2017
Closed
dstansby removed their assignment Apr 10, 2017
dstansby added a commit that referenced this pull request May 1, 2017
Merge pull request #8211 from NelleV/MEP12_text_labels_and_annotations
605e57b 
Mep12 text labels and annotations

dstansby commented May 1, 2017

Copy link
Copy Markdown
Member

Backported to 2.0.x via. 605e57b

QuLogic changed the title [MRG+1] Mep12 text labels and annotations Mep12 text labels and annotations May 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

QuLogic QuLogic approved these changes
anntzer anntzer approved these changes
dstansby dstansby approved these changes

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

v2.0.1

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL