FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Mep12 ticks and spines by NelleV · Pull Request #8212 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Mep12 ticks and spines - #8212

Merged
anntzer merged 4 commits into
matplotlib:masterfrom
NelleV:MEP12_ticks_and_spines
Mar 7, 2017
ConversationCommits (4)ChecksFiles changed
Merged

Mep12 ticks and spines#8212
anntzer merged 4 commits into
matplotlib:masterfrom
NelleV:MEP12_ticks_and_spines

Conversation

NelleV commented Mar 7, 2017

Copy link
Copy Markdown
Member

I've merged two examples and wrote documentation for a bunch of others.

refs #7206

NelleV changed the title Mep12 ticks and spines [MRG] Mep12 ticks and spines Mar 7, 2017
QuLogic changed the title [MRG] Mep12 ticks and spines [MRG+1] Mep12 ticks and spines Mar 7, 2017
tacaswell reviewed Mar 7, 2017
View reviewed changes
Comment thread examples/ticks_and_spines/spines_demo.py
ax2.plot(x, y)

# Only draw spine between the y-ticks
ax2.spines['left'].set_bounds(-1, 1)

tacaswell Mar 7, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Well, I learned something...

tacaswell added this to the 2.0.1 (next bug fix release) milestone Mar 7, 2017

tacaswell commented Mar 7, 2017

Copy link
Copy Markdown
Member

Please backport to 2.0.0-doc

NelleV changed the title [MRG+1] Mep12 ticks and spines [MRG+2] Mep12 ticks and spines Mar 7, 2017
anntzer requested changes Mar 7, 2017
View reviewed changes
Comment thread examples/ticks_and_spines/spines_demo.py Outdated
ax1.yaxis.set_ticks_position('left')
ax1.xaxis.set_ticks_position('bottom')


anntzer Mar 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

no need for two empty lines? (there's only one between ax0 and ax1)

Comment thread examples/ticks_and_spines/tick-locators.py Outdated
Tick locators
=============

Show the different tick locators

anntzer Mar 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Add a dot.

Comment thread examples/ticks_and_spines/spines_demo.py Outdated
======

This demo compares :
- normal axes, with spines on all four sides

anntzer Mar 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Add dots (or commas) at the end of each item.

Comment thread examples/ticks_and_spines/spines_demo.py Outdated
Spines
======

This demo compares :

anntzer Mar 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

no space before the colon (English typography :-))

NelleV commented Mar 7, 2017

Copy link
Copy Markdown
Member Author

I fixed the blank spaces/lines issues.

anntzer requested changes Mar 7, 2017
View reviewed changes

anntzer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

just being finicky...

Comment thread examples/ticks_and_spines/spines_demo.py Outdated
This demo compares:
- normal axes, with spines on all four sides;
- an axes with spines only on the left and bottom;
- an axes using custom bounds to limit the extent of the spine;

anntzer Mar 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

not at the end of the last item...

NelleV Mar 7, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

As a side note, when it starts being that nitpicky, it is much faster to fix it yourself before merging.

NelleV Mar 7, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

FYI, I didn't even bother doing it on my computer: I just did it through the github API.

anntzer Mar 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ah, I didn't know I could do it directly there... good point.

anntzer merged commit b2137d7 into matplotlib:master Mar 7, 2017

anntzer commented Mar 7, 2017

Copy link
Copy Markdown
Contributor

Thanks.

anntzer changed the title [MRG+2] Mep12 ticks and spines Mep12 ticks and spines Mar 7, 2017
QuLogic mentioned this pull request Mar 7, 2017
Closed
dstansby added the MEP: MEP12 gallery and examples improvements label Mar 25, 2017
dstansby pushed a commit that referenced this pull request Mar 25, 2017
Merge pull request #8212 from NelleV/MEP12_ticks_and_spines
6750f68 
Mep12 ticks and spines

dstansby commented Mar 25, 2017

Copy link
Copy Markdown
Member

Backported to 2.0.0-doc via. 6750f68

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tacaswell tacaswell approved these changes
QuLogic QuLogic approved these changes
anntzer anntzer approved these changes

Assignees

No one assigned

Labels

Documentation MEP: MEP12 gallery and examples improvements

Projects

None yet

Milestone

v2.0.1

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL