FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

MEP12 text alignment example by dstansby · Pull Request #8228 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

MEP12 text alignment example - #8228

Merged
anntzer merged 3 commits into
matplotlib:masterfrom
dstansby:alignment-example
Mar 8, 2017
ConversationCommits (3)ChecksFiles changed
Merged

MEP12 text alignment example#8228
anntzer merged 3 commits into
matplotlib:masterfrom
dstansby:alignment-example

Conversation

dstansby commented Mar 7, 2017

Copy link
Copy Markdown
Member

Another documentation update!

NelleV approved these changes Mar 7, 2017
View reviewed changes

NelleV left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!
Thanks @dstansby

NelleV changed the title MEP12 text alignment example [MRG+1] MEP12 text alignment example Mar 7, 2017
twmr reviewed Mar 7, 2017
View reviewed changes
Comment thread examples/text_labels_and_annotations/text_alignment.py
transform=ax.transAxes)

ax.text(left, 0.5*(bottom + top), 'right center',
ax.text(left, 0.5 * (bottom + top), 'right center',

twmr Mar 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm -1 on this and the following changes. Note that PEP8 AFAIK does not recommend to add whitespace before and after this operator.

anntzer Mar 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Actually it does, see https://www.python.org/dev/peps/pep-0008/#other-recommendations.

twmr Mar 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It says 'Use your own judgment;'

anntzer Mar 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

"If operators with different priorities are used, consider adding whitespace around the operators with the lowest priority(ies)."

twmr Mar 12, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

In the above line the operator with the lowest priority is the plus operator around which whitespace is added. PEP8 does not say anything about adding whitespace to all operators independent of their priorities.

anntzer requested changes Mar 7, 2017
View reviewed changes

anntzer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

feel free to dismiss the review if "to" is more colloquial

Comment thread examples/text_labels_and_annotations/text_alignment.py Outdated
You can precisely layout text in data or axes (0,1) coordinates. This
example shows you some of the alignment and rotation specifications to
layout text
layout text.

anntzer Mar 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

"for layout text"? (nonnative speaker here)

QuLogic Mar 7, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

"for text layout"

anntzer merged commit 355695a into matplotlib:master Mar 8, 2017

anntzer commented Mar 8, 2017

Copy link
Copy Markdown
Contributor

Thanks!

anntzer changed the title [MRG+1] MEP12 text alignment example MEP12 text alignment example Mar 8, 2017
dstansby deleted the alignment-example branch March 8, 2017 10:09
anntzer mentioned this pull request Mar 8, 2017
Closed
QuLogic added this to the 2.1 (next point release) milestone Apr 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

QuLogic QuLogic left review comments
anntzer anntzer requested changes
NelleV NelleV approved these changes
+1 more reviewer
twmr twmr left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

v2.1

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL