FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

changes to MEP12/sphinx-gallery compliant by mitchnegus · Pull Request #8233 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

changes to MEP12/sphinx-gallery compliant - #8233

Merged
anntzer merged 2 commits into
matplotlib:masterfrom
mitchnegus:MEP12_comp1
Mar 8, 2017
ConversationCommits (2)ChecksFiles changed
Merged

changes to MEP12/sphinx-gallery compliant#8233
anntzer merged 2 commits into
matplotlib:masterfrom
mitchnegus:MEP12_comp1

Conversation

mitchnegus commented Mar 8, 2017

Copy link
Copy Markdown
Contributor

In response to #7206; similar to #8209

NelleV approved these changes Mar 8, 2017
View reviewed changes

NelleV left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM 👍
Thanks!

Comment thread examples/mplot3d/pathpatch3d_demo.py
'''
"""

import numpy as np

NelleV Mar 8, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I wonder how this example even ran without numpy…

anntzer Mar 8, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It did not, so the question is, why was it not picked up by the gallery?

anntzer Mar 8, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

http://matplotlib.org/devdocs/examples/mplot3d/pathpatch3d_demo.html super confused now.

NelleV Mar 8, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

That is super wierd…

anntzer Mar 8, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you open an issue to track this?

NelleV changed the title changes to MEP12/sphinx-gallery compliant [MRG+1] changes to MEP12/sphinx-gallery compliant Mar 8, 2017
anntzer merged commit ddc9976 into matplotlib:master Mar 8, 2017

anntzer commented Mar 8, 2017

Copy link
Copy Markdown
Contributor

Thanks!

anntzer mentioned this pull request Mar 8, 2017
Closed
QuLogic changed the title [MRG+1] changes to MEP12/sphinx-gallery compliant changes to MEP12/sphinx-gallery compliant Mar 8, 2017

dstansby commented Mar 8, 2017

Copy link
Copy Markdown
Member

I know everyone is keen to merge doc related pull requests, but please wait until at least the documentation build and PEP8 build on travis are complete before merging.

It turns out this PR had a PEP8 violation that went by un-noticed.

dstansby mentioned this pull request Mar 8, 2017
Merged

anntzer commented Mar 8, 2017

Copy link
Copy Markdown
Contributor

Apologies.

mitchnegus mentioned this pull request Mar 22, 2017
Closed
dstansby pushed a commit that referenced this pull request Apr 30, 2017
Merge pull request #8233 from mnegus01/MEP12_comp1
1641eab 
[MRG+1] changes to MEP12/sphinx-gallery compliant
dstansby added this to the 2.0.1 (next bug fix release) milestone Apr 30, 2017

dstansby commented Apr 30, 2017

Copy link
Copy Markdown
Member

Backported to 2.0.x via. 1641eab

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

NelleV NelleV approved these changes
anntzer anntzer left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.0.1

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL