Repository navigation
DOC: missing API docs from #8032 - #8285
QuLogic merged 3 commits into
Conversation
Sorry, something went wrong.
afvincent
left a comment
There was a problem hiding this comment.
A few comments.
Additionally, I wonder if it would be useful to precise the PR that did this? (I know some other projects do this in their changelogs but I do not know if Matplotlib does)
Sorry, something went wrong.
| line width is smaller than the effective pixel size, this may result | ||
| in dashed lines turning into solid gray lines. This also required | ||
| slightly tweaking the default patterns for '--', ':', and '.-' so that | ||
| with the default line-width the final patterns would not change. |
There was a problem hiding this comment.
line-width <- line width? (to be consistent with the other utterances of the expression).
Beside, it is not totally true that the new default patterns are exactly the same as before (e.g. the dotted pattern that is not a 50 %-50 % pattern anymore). Maybe the sentence should just state that the default patterns were tweaked to remain similar with the default lw value as well as to avoid “cluttering” with line widths thiner than the previous clipping boundary.
Sorry, something went wrong.
| slightly tweaking the default patterns for '--', ':', and '.-' so that | ||
| with the default line-width the final patterns would not change. | ||
|
|
||
| There is no way to restore the old behavior |
There was a problem hiding this comment.
Closing period?
Sorry, something went wrong.
| Slightly change the algorithm to no longer clip the scaling factor, | ||
| thus the patterns will continue to shrink at thin line widths. If the | ||
| line width is smaller than the effective pixel size, this may result | ||
| in dashed lines turning into solid gray lines. This also required |
There was a problem hiding this comment.
Why gray?
Sorry, something went wrong.
There was a problem hiding this comment.
The line was implicitly black in my head when I wrote this.
Sorry, something went wrong.
Small tweaks to API documentation on scaling dashes
|
The same test is failing on three environments: do we have a problem on 2.0.x with the tests? |
Sorry, something went wrong.
NelleV
left a comment
There was a problem hiding this comment.
I don't know if my review counts, but this looks good to me.
LGTM 👍
Sorry, something went wrong.
missing API docs from #8032