Repository navigation
LogLocator: fix problems with minor ticks. Closes #8111. - #8381
Merged
NelleV merged 1 commit intoMar 30, 2017
Merged
NelleV merged 1 commit into
NelleV merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The subsetting of minor ticks that was introduced in v2.0 made it hard to know what number a given unlabeled minor tick represents, so we have decided that minor log ticks should be all integer multiples of the decade (except the decade itself). When major ticks skip decades, then minor ticks are omitted entirely.
phobson
approved these changes
Mar 30, 2017
phobson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks for this. Looks good to me.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The subsetting of minor ticks that was introduced in v2.0
made it hard to know what number a given unlabeled minor
tick represents, so we have decided that minor log ticks
should be all integer multiples of the decade (except the
decade itself).
When major ticks skip decades, then minor ticks are omitted
entirely.