FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Hatching gap on agg backend by mdboom · Pull Request #853 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Hatching gap on agg backend #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdboom merged 1 commit into from
Apr 27, 2012
Conversation 3 Commits 1 Checks 0 Files changed
Merged

Hatching gap on agg backend #853

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
33 changes: 12 additions & 21 deletions lib/matplotlib/hatch.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -43,37 +43,28 @@ def set_vertices_and_codes(self, vertices, codes):
class NorthEastHatch(HatchPatternBase):
def __init__(self, hatch, density):
self.num_lines = (hatch.count('/') + hatch.count('x') + hatch.count('X')) * density
self.num_vertices = self.num_lines * 4
self.num_vertices = (self.num_lines + 1) * 2

pelson Apr 26, 2012

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is not good when num_lines == 0 as we end up with a single point in the hatch pattern. 7242fd67921fff5c7651692e097cfdb7dde174ab, in my own branch from yours, fixes this and adds a fix to the anti-aliasing effect on horizontal and vertical hatches.

def set_vertices_and_codes(self, vertices, codes):
steps = np.linspace(0.0, 1.0, self.num_lines, False)
rev_steps = 1.0 - steps
vertices[0::4, 0] = 0.0
vertices[0::4, 1] = steps
vertices[1::4, 0] = rev_steps
vertices[1::4, 1] = 1.0
vertices[2::4, 0] = rev_steps
vertices[2::4, 1] = 0.0
vertices[3::4, 0] = 1.0
vertices[3::4, 1] = steps
steps = np.linspace(-0.5, 0.5, self.num_lines + 1, True)
vertices[0::2, 0] = 0.0 + steps
vertices[0::2, 1] = 0.0 - steps
vertices[1::2, 0] = 1.0 + steps
vertices[1::2, 1] = 1.0 - steps
codes[0::2] = Path.MOVETO
codes[1::2] = Path.LINETO

class SouthEastHatch(HatchPatternBase):
def __init__(self, hatch, density):
self.num_lines = (hatch.count('\\') + hatch.count('x') + hatch.count('X')) * density
self.num_vertices = self.num_lines * 4
self.num_vertices = (self.num_lines + 1) * 2

def set_vertices_and_codes(self, vertices, codes):
steps = np.linspace(0.0, 1.0, self.num_lines, False)
vertices[0::4, 0] = 1.0
vertices[0::4, 1] = steps
vertices[1::4, 0] = steps
vertices[1::4, 1] = 1.0
vertices[2::4, 0] = steps
vertices[2::4, 1] = 0.0
vertices[3::4, 0] = 0.0
vertices[3::4, 1] = steps
steps = np.linspace(-0.5, 0.5, self.num_lines + 1, True)
vertices[0::2, 0] = 0.0 + steps
vertices[0::2, 1] = 1.0 + steps
vertices[1::2, 0] = 1.0 + steps
vertices[1::2, 1] = 0.0 + steps
codes[0::2] = Path.MOVETO
codes[1::2] = Path.LINETO

Expand Down
Back | FazBrowse Home | New Git URL