Repository navigation
Fix AttributeError: 'QPixmap' object has no attribute 'setDevicePixelRatio' - #8559
Merged
tacaswell merged 1 commit intoMay 3, 2017
Merged
tacaswell merged 1 commit into
tacaswell merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
efiring
approved these changes
May 2, 2017
efiring
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This looks right to me, and appears to be the only place where the conditional was missed.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re #8440.
Using matplotlib-2.0.1 with PyQt4‑4.11.4, the example embedding_in_qt4_wtoolbar.py fails:
X:\Python36\lib\site-packages\matplotlib\backends\qt4_compat.py:10: MatplotlibDeprecationWarning: This module has been deprecated in 1.4 in favor of matplotlib.backends.qt_compat This module will be removed in 1.5, please update your imports. warnings.warn(_warn_str, mplDeprecation) Traceback (most recent call last): File "embedding_in_qt4_wtoolbar.py", line 74, in <module> main() File "embedding_in_qt4_wtoolbar.py", line 69, in main form = AppForm() File "embedding_in_qt4_wtoolbar.py", line 27, in __init__ self.create_main_frame() File "embedding_in_qt4_wtoolbar.py", line 39, in create_main_frame self.mpl_toolbar = NavigationToolbar(self.canvas, self.main_frame) File "X:\Python36\lib\site-packages\matplotlib\backends\backend_qt5.py", line 585, in __init__ NavigationToolbar2.__init__(self, canvas) File "X:\Python36\lib\site-packages\matplotlib\backend_bases.py", line 2760, in __init__ self._init_toolbar() File "X:\Python36\lib\site-packages\matplotlib\backends\backend_qt5.py", line 601, in _init_toolbar a = self.addAction(self._icon(image_file + '.png'), File "X:\Python36\lib\site-packages\matplotlib\backends\backend_qt5.py", line 591, in _icon pm.setDevicePixelRatio(self.canvas._dpi_ratio) AttributeError: 'QPixmap' object has no attribute 'setDevicePixelRatio'