FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Final batch of pylab example moves by dstansby · Pull Request #8983 · matplotlib/matplotlib · GitHub

Repository navigation

Final batch of pylab example moves - #8983

Merged
NelleV merged 3 commits into
matplotlib:masterfrom
dstansby:pylab-moves
Aug 3, 2017
Merged

NelleV merged 3 commits into
matplotlib:masterfrom
dstansby:pylab-moves

Conversation

dstansby commented Aug 2, 2017

Copy link
Copy Markdown
Member

Again, first commit is moves, second commit is PEP8, third commit is link fixing.

dstansby added Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labels Aug 2, 2017
dstansby added this to the 2.1 (next point release) milestone Aug 2, 2017

QuLogic left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not sure about the anchored_artists.py example. It seems to be duplicating the classes that already exist in the library, either matplotlib.offsetbox or mpl_toolkits.axes_grid1. Probably most of it can be replaced with suitable imports?

LGTM otherwise.

@@ -11,7 +11,8 @@


class AnchoredText(AnchoredOffsetbox):

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I wonder if we need this class when there's a matplotlib.offsetbox.AnchoredText implementation already?

@@ -26,8 +27,8 @@ class AnchoredSizeBar(AnchoredOffsetbox):
def __init__(self, transform, size, label, loc,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

And AnchoredSizeBar is in mpl_toolkits.axes_grid1.AnchoredSizeBar.

QuLogic mentioned this pull request Aug 3, 2017
6 tasks done
)

#fig.subplots_adjust(top=0.99, bottom=0.01, left=0.2, right=0.99)
# fig.subplots_adjust(top=0.99, bottom=0.01, left=0.2, right=0.99)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I guess at some point we should clean this up and just delete those lines of codes.

NelleV merged commit 6179526 into matplotlib:master Aug 3, 2017
QuLogic mentioned this pull request Aug 3, 2017

Copy link
Copy Markdown
Contributor

Partially resolves #8922

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL