FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

WIP: Testing getting AppVeyor working [DO NOT MERGE] by dopplershift · Pull Request #9282 · matplotlib/matplotlib · GitHub

Repository navigation

WIP: Testing getting AppVeyor working [DO NOT MERGE] - #9282

Closed
dopplershift wants to merge 1 commit into
matplotlib:masterfrom
dopplershift:test-appveyor
Closed

dopplershift wants to merge 1 commit into
matplotlib:masterfrom
dopplershift:test-appveyor

Conversation

Copy link
Copy Markdown
Contributor

It seems that adding this test is when things started going sideways...

This, somehow, seems to be where things started going sideways...

Copy link
Copy Markdown
Member

This makes very little sense to me...

Copy link
Copy Markdown
Contributor Author

Two separate successful AppVeyor runs confirm it's related, though.

Copy link
Copy Markdown
Member

Combined with the fact that adding -v to the tests seems to move the segfault to the end and that @cgohlke reports that this is dependent on a python mirco version makes me hope that this is something upstream in how BytesIO or bytes are handled.

It looks like there is a path (which we don't test?) that saves everything into memory and then embeds the frames. I think the code path we are testing is writing to a temporary directory.

QuLogic commented Oct 6, 2017

Copy link
Copy Markdown
Member

It's now the third time around and still passing...

tacaswell added this to the 2.1.1 (next bug fix release) milestone Oct 6, 2017
Kojoley closed this Oct 14, 2017
Kojoley removed this from the 2.1.1 milestone Oct 14, 2017
dopplershift deleted the test-appveyor branch October 15, 2017 13:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL