Repository navigation
Restore better error message on std::runtime_error. - #9299
Merged
tacaswell merged 1 commit intoOct 7, 2017
Merged
tacaswell merged 1 commit into
tacaswell merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Kojoley
approved these changes
Oct 6, 2017
Kojoley
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
dopplershift
approved these changes
Oct 6, 2017
Copy link
Copy Markdown
Member
|
Looks like you need to fix the test now. |
Sorry, something went wrong.
Kojoley
requested changes
Oct 6, 2017
Kojoley
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Oh. You have to place std::runtime_error handling after std::overflow_error because second inherits first and std::runtime_error catches both.
Sorry, something went wrong.
anntzer
force-pushed
the
c++-std-runtime_error
branch
from
d6661f9 to
be87212
Compare
October 6, 2017 23:35
Copy link
Copy Markdown
Contributor
Author
|
fixed |
Sorry, something went wrong.
Kojoley
approved these changes
Oct 7, 2017
tacaswell
added a commit
that referenced
this pull request
Oct 8, 2017
Backport PR #9299 on branch v2.1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
attn @Kojoley #9289 (comment)
PR Summary
PR Checklist