FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Document get_{x,y}axis_transform more prominently. by anntzer · Pull Request #9375 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Document get_{x,y}axis_transform more prominently. - #9375

Merged
jklymak merged 1 commit into
matplotlib:masterfrom
anntzer:doc-transforms-tutorial
Oct 11, 2017
ConversationCommits (1)ChecksFiles changed
Merged

Document get_{x,y}axis_transform more prominently.#9375
jklymak merged 1 commit into
matplotlib:masterfrom
anntzer:doc-transforms-tutorial

Conversation

anntzer commented Oct 11, 2017

Copy link
Copy Markdown
Contributor

They are quite useful but right now are documented in a slightly obscure
manner.

Closes #9369.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

jklymak requested changes Oct 11, 2017
View reviewed changes

jklymak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

small typo

Comment thread tutorials/advanced/transforms_tutorial.py Outdated
=========== ============================= =====================================
Coordinates Transformation object Description
=========== ============================= =====================================
"data" ``ax.transData```` The userland data coordinate system,

jklymak Oct 11, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What is a "userland"?

anntzer Oct 11, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

"from the POV of the user" but I agree it's a bit obscure. "The data coordinate system" actually sounds good enough?

anntzer Oct 11, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

force pushed (also fixed below)

Comment thread tutorials/advanced/transforms_tutorial.py Outdated
display, and (width, height) is top
right of the display in pixels.
"xaxis", ``ax.get_xaxis_transform()``, Blended coordinate systems; use data
"yaxis" ``ax.get_yaxis_transform()`` coordinates one one of the axis and

jklymak Oct 11, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

one one -> on one

anntzer force-pushed the doc-transforms-tutorial branch from 938cbdc to 8d8a3fc Compare October 11, 2017 22:33
Document get_{x,y}axis_transform more prominently.
f19eddb 
They are quite useful but right now are documented in a slightly obscure
manner.
anntzer force-pushed the doc-transforms-tutorial branch from 8d8a3fc to f19eddb Compare October 11, 2017 22:35
jklymak merged commit de51d40 into matplotlib:master Oct 11, 2017

jklymak commented Oct 11, 2017

Copy link
Copy Markdown
Member

... there I went nuts and merged it. Hope that was OK - docs just require one approval, right?

jklymak mentioned this pull request Oct 11, 2017
Closed
anntzer deleted the doc-transforms-tutorial branch October 11, 2017 23:42
dstansby added this to the 2.1.0-docs milestone Oct 12, 2017
tacaswell pushed a commit that referenced this pull request Oct 12, 2017
Merge pull request #9375 from anntzer/doc-transforms-tutorial
d5a3e46 
Document get_{x,y}axis_transform more prominently.

tacaswell commented Oct 12, 2017

Copy link
Copy Markdown
Member

backported to v2.1.0-doc as d5a3e46

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jklymak jklymak approved these changes

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

v2.1.0-doc

Development

Successfully merging this pull request may close these issues.

2.1 - new problem with log ax.transData

4 participants

Back | FazBrowse Home | New Git URL