Repository navigation
TST: Unblock Appveyor build by patching subprocess - #9395
tacaswell merged 1 commit into
Conversation
Sorry, something went wrong.
|
|
||
| # Apply patch to `subprocess` on Python versions > 2 and < 3.6.3 | ||
| # https://github.com/matplotlib/matplotlib/issues/9176 | ||
| - python -c "import sys; sys.exit((2,) > sys.version_info > (3,6,3))" && ( |
There was a problem hiding this comment.
Shouldn't this be sys.exit((3,6,3) > sys.version_info > (2,)) ?
Sorry, something went wrong.
There was a problem hiding this comment.
Yes, I wrongly negated the (2,) < sys.version_info < (3,6,3) expression.
Sorry, something went wrong.
| # https://github.com/matplotlib/matplotlib/issues/9176 | ||
| - python -c "import sys; sys.exit(not (2,) < sys.version_info < (3,6,3))" && ( | ||
| curl -sL https://github.com/python/cpython/pull/1224.patch | | ||
| patch -fsup 1 -d %CONDA_PREFIX% ) || ( set errorlevel= ) |
There was a problem hiding this comment.
I thought only Py3 was affected? Both from my (possibly incorrect) remembering of what used to fail and from https://bugs.python.org/issue30121#msg300658
If it's only a py3 issue then the lower bound should be (3,); if not we can just drop the lower bound (it's not as if we will ever support py1.5 anyways :-)).
Sorry, something went wrong.
There was a problem hiding this comment.
The bug was fixed 4 years ago in Py2. Python >= 2.7.6 should not be affected.
Sorry, something went wrong.
Backport PR #9395 on branch v2.1.x
closes #9176